Skip to content

Release/1238.0.0 - #10124

Merged
jpuri merged 6 commits into
mainfrom
release/1238.0.0
Sep 7, 2026
Merged

Release/1238.0.0#10124
jpuri merged 6 commits into
mainfrom
release/1238.0.0

Conversation

@jpuri

@jpuri jpuri commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Explanation

Release @metamask/transaction-controller.

References

https://consensyssoftware.atlassian.net/browse/CONF-1725

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
The release propagates a transaction-controller fix in gas preflight and external-sign handling, which affects signing and fee flows across many packages even though the diff is mostly version bumps.

Overview
This release cuts @metamask/transaction-controller 69.8.1 and rolls it through the monorepo as 1238.0.0.

The patch fixes gas fee token preflight: pending gas estimates are no longer treated as zero-cost native gas, and isExternalSign is cleared when preflight validation fails (#10071). Dependent packages (assets, bridge, wallet, phishing, smart transactions, and others) only bump their @metamask/transaction-controller range to ^69.8.1 and record the bump in their changelogs; yarn.lock is updated accordingly. There is no new application logic outside transaction-controller in this diff.

Reviewed by Cursor Bugbot for commit a795ef5. Bugbot is set up for automated code reviews on this repo. Configure here.

Record the 69.9.0 upgrade for packages that depend on transaction-controller, updating existing Unreleased bump lines in place.
@jpuri
jpuri marked this pull request as ready for review September 7, 2026 09:31
@jpuri
jpuri requested review from a team as code owners September 7, 2026 09:31
@jpuri
jpuri enabled auto-merge September 7, 2026 09:32
@jpuri
jpuri deployed to default-branch September 7, 2026 09:32 — with GitHub Actions Active
@jpuri
jpuri deployed to default-branch September 7, 2026 09:32 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown

❌ Changelog validation failed. Check the workflow run for details.

…og entries

Keep 69.9.0 consumer-facing by removing test-helper, Typedoc, and lint-rule notes that auto-changelog left Uncategorized.

## [Unreleased]

## [69.9.0]

@cryptodev-2s cryptodev-2s Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes are considered as patches would you mind changing this ?

Suggested change
## [69.9.0]
## [69.8.1]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — @metamask/transaction-controller is now 69.8.1 (patch), and dependent ranges/changelogs are aligned to ^69.8.1.

Treat the gas-fee-token preflight fix as a patch bump instead of a minor, and align dependent ranges and changelogs.
@jpuri
jpuri added this pull request to the merge queue Sep 7, 2026
Merged via the queue into main with commit e7b5a1b Sep 7, 2026
140 checks passed
@jpuri
jpuri deleted the release/1238.0.0 branch September 7, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants