Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

MetaMask / core Public

Notifications You must be signed in to change notification settings
Fork 281
Star 405

Code
Issues 309
Pull requests 283
Actions
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security and quality
Insights

Allow side-effects to permissions#1069

Merged

GuillaumeRx merged 32 commits into

mainMetaMask/core:mainfrom

gr/add-side-effect-permission-controllerMetaMask/core:gr/add-side-effect-permission-controllerCopy head branch name to clipboard

Mar 28, 2023

Conversation Commits32 (32)Checks Files changed

Merged

Allow side-effects to permissions#1069
GuillaumeRx merged 32 commits into
mainfrom
gr/add-side-effect-permission-controller

Commits

Commits on Mar 28, 2023

add side-effects to permissions
GuillaumeRx
committed
add missing origin parameter
GuillaumeRx
committed
add logic to handle failure and success of side effects
GuillaumeRx
committed
update error message
GuillaumeRx
committed
move side effects handling to approval controller
GuillaumeRx
committed
add tests to approval controller and improve logic
GuillaumeRx
committed
fix failure logic
GuillaumeRx
committed
pass requestData to side-effect hooks and revert changes to grantPermissions
GuillaumeRx
committed
revert more changes in PermissionController
GuillaumeRx
committed
remove useless type
GuillaumeRx
committed
re-add passing of side-effects to approvals
GuillaumeRx
committed
fix approval resolving
GuillaumeRx
committed
add tests to PermissionController
GuillaumeRx
committed
adjust branch coverage threshold for permission controller
GuillaumeRx
committed
pass messenger call method to side effect handler params
GuillaumeRx
committed
rework types
GuillaumeRx
committed
display error on failure
GuillaumeRx
committed
return values from side-effects
GuillaumeRx
committed
add missing test
GuillaumeRx
committed
pass entire messenger
GuillaumeRx
committed
update type
GuillaumeRx
committed
update side-effect messenger type
GuillaumeRx
committed
address requested changes and impove sideEffect types
GuillaumeRx
committed
add missing parameter to `add` jsdoc
GuillaumeRx
committed
move side-effect handling to `PermissionController`
GuillaumeRx
committed
fixing tests
GuillaumeRx
committed
add tests
GuillaumeRx
committed
revert useless change
GuillaumeRx
committed
add JSDocs and address requested changes
GuillaumeRx
committed
add more JSDocs
GuillaumeRx
committed
pass the entire approved request to side-effects
GuillaumeRx
committed
fix side effect return mappin unexpected behaviour
GuillaumeRx
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.