Add declaration files for TypeScript consumers#116
Merged
danfinlay merged 2 commits intoMetaMask:developfrom Jun 13, 2019
Merged
Add declaration files for TypeScript consumers#116danfinlay merged 2 commits intoMetaMask:developfrom
danfinlay merged 2 commits intoMetaMask:developfrom
Conversation
danfinlay
approved these changes
Jun 13, 2019
Codecov Report
@@ Coverage Diff @@
## develop #116 +/- ##
======================================
Coverage 100% 100%
======================================
Files 21 21
Lines 1429 1430 +1
Branches 193 193
======================================
+ Hits 1429 1430 +1
Continue to review full report at Codecov.
|
estebanmino
added a commit
that referenced
this pull request
Jun 14, 2019
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* tsc: Add declaration files to dist folder * Export BN type used for TokenBalancesState
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* tsc: Add declaration files to dist folder * Export BN type used for TokenBalancesState
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
* Added getAccounts suppressUnauthorized param * Fixed linting * Update src/wallet.ts Co-authored-by: Shane <jonas.shane@gmail.com> * Added unauthorized error when account is provided but is not returned from getAccounts * Added tests for unauthorized * Update test/wallet.test.ts Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * Update test/wallet.test.ts Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * Update test/wallet.test.ts Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * Update test/wallet.test.ts Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * Fixed linting * Fixed signTransaction test * Changed param to object Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com> Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
The `suppressUnauthorized` option has been removed from the type signature of the `getAccounts` parameter accepted by the `wallet` middleware. This option was added in #116 to fix an extension bug, but it was never used in practice. The linked extension change used the wrong parameter name (`suppressUnauthorizedError`), so this was always unset. We didn't notice because it also wasn't needed to fix the bug; the `resemblesAddress` condition added in that same PR was sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the TypeScript config to produce type declaration files into the
distfolder, allowing TypeScript consumers to properly get type information. I've exportedBNfromTokenBalancesController.tsas it's used in theTokenBalancesState, which itself is public.