Simplify BaseController#unsubscribe return statement#127
Merged
whymarrh merged 2 commits intoMetaMask:developfrom Jul 2, 2019
Merged
Simplify BaseController#unsubscribe return statement#127whymarrh merged 2 commits intoMetaMask:developfrom
whymarrh merged 2 commits intoMetaMask:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #127 +/- ##
======================================
Coverage 100% 100%
======================================
Files 21 21
Lines 1432 1432
Branches 194 193 -1
======================================
Hits 1432 1432
Continue to review full report at Codecov.
|
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Bumps [@metamask/utils](https://github.com/MetaMask/utils) from 3.4.0 to 3.4.1. - [Release notes](https://github.com/MetaMask/utils/releases) - [Changelog](https://github.com/MetaMask/utils/blob/main/CHANGELOG.md) - [Commits](MetaMask/utils@v3.4.0...v3.4.1) --- updated-dependencies: - dependency-name: "@metamask/utils" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Not all of the types within `./src/utils/cache.ts` seemed to be solely related to caching. These have been extracted to a separate file, and the main file has been updated to export `SafeEventEmitterProvider` from this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the return statement in
BaseController#unsubscribewhere we were previously testing a boolean and returning the same value.