keyring-controller: validate from-address in signTypedMessage#1293
Merged
legobeat merged 2 commits intoMetaMask:mainfrom May 3, 2023
Merged
keyring-controller: validate from-address in signTypedMessage#1293legobeat merged 2 commits intoMetaMask:mainfrom
legobeat merged 2 commits intoMetaMask:mainfrom
Conversation
legobeat
force-pushed
the
fix-sign-empty-address
branch
2 times, most recently
from
35b9b1d to
4705ae4
Compare
mikesposito
reviewed
May 2, 2023
Member
mikesposito
left a comment
mikesposito
left a comment
There was a problem hiding this comment.
Looks good! Left just a small suggestion
| ) { | ||
| try { | ||
| const address = normalizeAddress(messageParams.from); | ||
| if (!address?.length) { |
Member
There was a problem hiding this comment.
Nit: maybe we can use isValidAddress from ethereumjs-util to be sure that what we get is an address
Contributor
Author
There was a problem hiding this comment.
Updated along with PR title.
legobeat
force-pushed
the
fix-sign-empty-address
branch
from
cdf3025 to
8b42427
Compare
legobeat
force-pushed
the
fix-sign-empty-address
branch
from
8b42427 to
67d33ef
Compare
legobeat
changed the title
legobeat
changed the title
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* keyring-controller: throw explicit error on undefined result from normalizeAddress * key-controller: validate sender address before attempting signature
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* keyring-controller: throw explicit error on undefined result from normalizeAddress * key-controller: validate sender address before attempting signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
normalizeAddressfunction is can returnundefinedeven if the interface says otherwise.This adds explicit handling of that case in
keyring-controller. Required for #1289 .