docs: update controller-utils/isValidHexAddress to match reality#1308
Merged
legobeat merged 2 commits intoMetaMask:mainfrom May 3, 2023
Merged
docs: update controller-utils/isValidHexAddress to match reality#1308legobeat merged 2 commits intoMetaMask:mainfrom
legobeat merged 2 commits intoMetaMask:mainfrom
Conversation
originally added in 82386c4
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
originally added in 82386c4
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
originally added in 82386c4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The jsdoc references non-existent parameter and behavior. This updates the doc to match reality.
Minor rewrite to make it clear that input is left unmodified.
Changes
controller-utils: isValidHexAddress doesn't describe actual behaviorReferences
Originally added in 82386c4, seemingly reflecting a past and forgotten image of how things would have been.
Checklist