fix: Ensure that network client ID is updated before use

[FrederikBolding]

Explanation

This PR fixes a rare problem that would occur when deleting a network after a proxy in SelectedNetworkController has been garbage collected. When this happens, getProviderAndBlockTracker will fail to find the old network client ID and thus updating the network client ID for the domain will fail.

This could be reproduced in an E2E test that would only fail on this branch: MetaMask/metamask-extension#27306 which enables initialConnections for a preinstalled Snap. initialConnections adds a permission for an origin to connect to a Snap which causes the SelectedNetworkController to register the domain. My theory is that since the user has not accessed the origin in question yet, the proxy may not be used and may be garbage collected. If a network is deleted following that, an error occurs.

Changelog

@metamask/selected-network-controller

• Fixed: Ensure that network client ID is updated before using it

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[adonesky1]

LGTM