Fix invalid type import path in @metamask/multichain - #5313
Merged
Conversation
Mrtenz
force-pushed
the
mrtenz/fix-type-import
branch
from
February 12, 2025 10:48
4c59e50 to
a89a0a4
Compare
Mrtenz
marked this pull request as ready for review
February 12, 2025 10:53
FrederikBolding
approved these changes
Feb 12, 2025
ffmcgee725
approved these changes
Feb 12, 2025
Mrtenz
force-pushed
the
mrtenz/fix-type-import
branch
from
February 12, 2025 12:45
a89a0a4 to
54a21bb
Compare
Mrtenz
force-pushed
the
mrtenz/fix-type-import
branch
from
February 12, 2025 12:53
54a21bb to
745a2b9
Compare
Mrtenz
enabled auto-merge (squash)
February 12, 2025 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
@metamask/multichainwas importingsrc/scope/types, which does not work when importing the library in other projects. I've changed it to../scope/typesinstead.Changelog
@metamask/multichainChecklist