Skip to content

Fix invalid type import path in @metamask/multichain - #5313

Merged
Mrtenz merged 2 commits into
mainfrom
mrtenz/fix-type-import
Feb 12, 2025
Merged

Fix invalid type import path in @metamask/multichain#5313
Mrtenz merged 2 commits into
mainfrom
mrtenz/fix-type-import

Conversation

@Mrtenz

@Mrtenz Mrtenz commented Feb 12, 2025

Copy link
Copy Markdown
Member

Explanation

@metamask/multichain was importing src/scope/types, which does not work when importing the library in other projects. I've changed it to ../scope/types instead.

Changelog

@metamask/multichain

  • FIXED: Fix invalid type import path

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Mrtenz
Mrtenz force-pushed the mrtenz/fix-type-import branch from 4c59e50 to a89a0a4 Compare February 12, 2025 10:48
@Mrtenz
Mrtenz marked this pull request as ready for review February 12, 2025 10:53
@Mrtenz
Mrtenz requested a review from a team as a code owner February 12, 2025 10:53
@Mrtenz
Mrtenz force-pushed the mrtenz/fix-type-import branch from a89a0a4 to 54a21bb Compare February 12, 2025 12:45
@Mrtenz
Mrtenz force-pushed the mrtenz/fix-type-import branch from 54a21bb to 745a2b9 Compare February 12, 2025 12:53
@Mrtenz
Mrtenz enabled auto-merge (squash) February 12, 2025 12:53
@Mrtenz
Mrtenz merged commit 1f7e0b9 into main Feb 12, 2025
@Mrtenz
Mrtenz deleted the mrtenz/fix-type-import branch February 12, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants