fix: Preserve data.cause when deserializing#7838
Merged
Merged
Conversation
GuillaumeRx
previously approved these changes
Feb 4, 2026
Mrtenz
previously approved these changes
Feb 4, 2026
FrederikBolding
dismissed stale reviews from mcmire, Mrtenz, and GuillaumeRx
via
0b69ef4
FrederikBolding
commented
Feb 4, 2026
| code: errorCodes.rpc.resourceUnavailable, | ||
| message: 'RPC endpoint not found or unavailable.', | ||
| data: { | ||
| data: expect.objectContaining({ |
Member
Author
There was a problem hiding this comment.
cause can now be null in these tests where previously it was undefined.
@mcmire Are you good with this workaround?
Mrtenz
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Preserve
data.causeif it exists when deserializing errors from legacy middlewares.This bug prevents us from using
JsonRpcEngineV2for Snaps.Note
Low Risk
Low risk: small, localized change to error deserialization that only affects how
data.causeis merged; covered by a new unit test and a minor test expectation adjustment downstream.Overview
Fixes
deserializeError/compatibility deserialization so that whendatais an object, an existingdata.causeis preserved (and not overwritten by anundefinedtop-levelcause).Adds a regression test for wrapped Snap-style errors and updates a
network-controllertest matcher to tolerate additional errordatafields. Also documents the fix in the@metamask/json-rpc-enginechangelog.Written by Cursor Bugbot for commit 83d74a5. This will update automatically on new commits. Configure here.