Skip to content

Comments

feat: add input_amount_preset to SwapBridge Input Changed#7987

Merged
infiniteflower merged 4 commits intomainfrom
swaps-3893-input-amount-preset
Feb 19, 2026
Merged

feat: add input_amount_preset to SwapBridge Input Changed#7987
infiniteflower merged 4 commits intomainfrom
swaps-3893-input-amount-preset

Conversation

@infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Feb 18, 2026

Explanation

This PR adds input_amount_preset field to Unified SwapBridge Input Changed.

References

Resolves https://consensyssoftware.atlassian.net/browse/SWAPS-3893
Related to https://github.com/Consensys/segment-schema/pull/462

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Type-only analytics schema extension (optional field + new enum export) with no runtime behavior changes; main risk is downstream TypeScript/build breakage for consumers with strict typings or enum name collisions.

Overview
Adds support for tracking amount-selection presets on Unified SwapBridge analytics by introducing a new InputAmountPreset enum and exporting it from the package entrypoint.

Extends the RequiredEventContextFromClient typing for the UnifiedSwapBridgeEventName.InputChanged event with an optional input_amount_preset field, and documents the new optional property in the bridge-controller changelog.

Written by Cursor Bugbot for commit e5c8d97. This will update automatically on new commits. Configure here.

@infiniteflower infiniteflower marked this pull request as ready for review February 18, 2026 20:14
@infiniteflower infiniteflower requested review from a team as code owners February 18, 2026 20:14
@infiniteflower infiniteflower force-pushed the swaps-3893-input-amount-preset branch from 4485592 to e5c8d97 Compare February 18, 2026 20:49
@infiniteflower infiniteflower added this pull request to the merge queue Feb 19, 2026
@infiniteflower infiniteflower removed this pull request from the merge queue due to a manual request Feb 19, 2026
@infiniteflower infiniteflower added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main with commit 1a84675 Feb 19, 2026
529 of 613 checks passed
@infiniteflower infiniteflower deleted the swaps-3893-input-amount-preset branch February 19, 2026 16:28
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2026
## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

Aligns the preset enum to what is in production, fixes the enum to use
75% instead of 90%.

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

Related Consensys/segment-schema#467
Related #7987

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [x] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Small code change, but it alters a public exported enum used in
metrics event typing, which can break downstream consumers that still
reference `PERCENT_90`.
> 
> **Overview**
> Updates bridge-controller metrics constants by **replacing the
`InputAmountPreset` value `PERCENT_90` with `PERCENT_75`**, aligning the
preset options with production.
> 
> Documents the change in the package changelog under *Unreleased* so
consumers know the enum value set has changed.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
e518506. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants