Skip to content

chore: Update Delegation controllers to expose all methods through messenger #8205

Merged
Mrtenz merged 7 commits intomainfrom
mrtenz/delegation-method-actions
Mar 20, 2026
Merged

chore: Update Delegation controllers to expose all methods through messenger #8205
Mrtenz merged 7 commits intomainfrom
mrtenz/delegation-method-actions

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented Mar 16, 2026

Explanation

This updates the following controllers to expose all methods through the messenger in a standardised way:

  • DelegationController.
  • GatorPermissionsController.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Expands each controller’s public messenger surface area and changes how actions are registered/called, which could affect downstream consumers relying on previous action typings/exports, though core logic is largely unchanged.

Overview
Standardizes messenger exposure for DelegationController and GatorPermissionsController by registering all public methods via messenger.registerMethodActionHandlers and adding generated *-method-action-types.ts unions for the corresponding action types.

Updates exports/types so DelegationControllerGetStateAction and the new method-action types are publicly available, and refactors tests to invoke controller behavior through rootMessenger.call(...) rather than direct method calls. Adds tsx plus a generate-method-action-types script to both packages and records the API exposure in changelogs.

Written by Cursor Bugbot for commit d3257e4. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz changed the title Mrtenz/delegation method actions chore: Update Delegation controllers to expose all methods through messenger Mar 16, 2026
@Mrtenz Mrtenz marked this pull request as ready for review March 16, 2026 14:35
@Mrtenz Mrtenz requested review from a team as code owners March 16, 2026 14:35
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things, but otherwise looks good.

Comment thread packages/delegation-controller/src/index.ts Outdated
Comment thread packages/gator-permissions-controller/src/index.ts Outdated
@Mrtenz Mrtenz force-pushed the mrtenz/delegation-method-actions branch from 694e1d8 to 3aba88d Compare March 17, 2026 11:50
Comment thread packages/delegation-controller/CHANGELOG.md Outdated
@Mrtenz Mrtenz force-pushed the mrtenz/delegation-method-actions branch from 6fd6620 to d3257e4 Compare March 18, 2026 13:03
@Mrtenz Mrtenz enabled auto-merge March 18, 2026 15:10
@Mrtenz Mrtenz added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 8e966dd Mar 20, 2026
322 checks passed
@Mrtenz Mrtenz deleted the mrtenz/delegation-method-actions branch March 20, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants