chore: drop analytics-controller from lint:tsc

[cryptodev-2s]

Explanation

analytics-controller is enrolled in lint:tsc (it has a tsconfig.lint.json and is listed in the root tsconfig.lint.json). Once it starts importing geolocation-controller and controller-utils (the geo enrichment work in #9691), and neither of those is a lint:tsc project yet, tsc pulls their source straight into the analytics-controller project and fails with rootDir errors:

error TS6059: File '.../controller-utils/src/types.ts' is not under 'rootDir' '.../analytics-controller'
error TS6307: File '.../controller-utils/src/types.ts' is not listed within the file list of project '.../analytics-controller/tsconfig.lint.json'

This turns the lint:tsc job red on #9691 and blocks the work.

This PR removes packages/analytics-controller/tsconfig.lint.json and its entry in the root tsconfig.lint.json, so analytics-controller is no longer type checked by lint:tsc. yarn lint:tsc is green with this change.

This is a stopgap to unblock the current work, not the end state. The proper fix is to make controller-utils and geolocation-controller lint:tsc projects (give them their own tsconfig.lint.json) and enroll analytics-controller again. That is a bigger change because it also turns on type checking for those packages' test files, which surfaces separate pre existing type errors that need their own cleanup.

References

• Unblocks feat: geo-enrich analytics events via GeolocationController #9691

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them