chore: bump accounts deps - #9754
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| languageName: unknown | ||
| linkType: soft | ||
|
|
||
| "@metamask/eth-money-keyring@npm:^2.0.4": |
There was a problem hiding this comment.
Going from 2 to 4 here, but the client (feature available on mobile only for now) was already using previous major 3. The new major 4 is mostly because we removed some EOL node.js support, so no real bad surprises to be expected here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cf0e708. Configure here.
| exportable: false, | ||
| }, | ||
| methods: [ | ||
| EthMethod.SignTransaction, |
There was a problem hiding this comment.
Removing this now. Since @metamask/eth-money-keyring@3.0.0 the handler for this method got removed. Those accounts are not supposed to sign transactions.
The mobile client (only client that uses money accounts for now), is already using this version too: https://github.com/MetaMask/metamask-mobile/blob/920629a885551f8dbf4ab523b1a4b352d9a84cd2/package.json#L288
I'll make a migration to clear up this method from the existing money accounts once aligning our deps there!
| ### Changed | ||
|
|
||
| - Bump `@metamask/keyring-api` from `^23.7.0` to `^24.0.0` ([#9754](https://github.com/MetaMask/core/pull/9754)) | ||
| - Bump `@metamask/superstruct` from `^3.1.0` to `^3.4.1` ([#9754](https://github.com/MetaMask/core/pull/9754)) |
There was a problem hiding this comment.
Also bumping @metamask/superstruct since I'll soon use the new sensitive struct from this version!

Explanation
Aligning
accountsdeps.References
accountsdeps + removeeth_signTransactionfrom Money accounts metamask-mobile#34191Checklist
Note
Medium Risk
Touches many packages that depend on the keyring and account APIs with several major semver upgrades, but the PR does not change controller logic—risk is mainly version skew and downstream breaking API behavior from the bumped packages.
Overview
This PR aligns MetaMask accounts/keyring dependency versions across many
packages/*workspaces so core stays in sync with extension and mobile consumers (#9754).Keyring stack (major bumps):
@metamask/keyring-api^24.0.0,@metamask/keyring-internal-api^12.0.0,@metamask/keyring-utils^5.0.0,@metamask/keyring-sdk^3.1.0,@metamask/account-api^2.0.0,@metamask/eth-snap-keyring^24.0.0,@metamask/keyring-snap-client^10.0.0, and related bumps on HD/simple/money keyrings and snap clients. Controllers such askeyring-controller,accounts-controller,multichain-account-service, andsnap-account-servicepick these up viapackage.jsononly.Validation library:
@metamask/superstructis raised from ^3.1.0 to ^3.4.1 broadly (RPC middleware, wallet-cli, data services, etc.).Changes are lockfile + changelog entries; there are no application source edits in this diff.
Reviewed by Cursor Bugbot for commit 81a0d30. Bugbot is set up for automated code reviews on this repo. Configure here.