Skip to content

docs(assets-controllers): add spot-prices example URL for dev verification - #9878

Merged
Prithpal-Sooriya merged 3 commits into
mainfrom
cursor/spot-prices-example-url-comment-7706
Aug 14, 2026
Merged

docs(assets-controllers): add spot-prices example URL for dev verification#9878
Prithpal-Sooriya merged 3 commits into
mainfrom
cursor/spot-prices-example-url-comment-7706

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Restructures verification comments above SPOT_PRICES_SUPPORT_INFO in codefi-v2.ts:

// Price API v3/spot-prices chains only — verify support before adding:
// Source: https://github.com/consensys-vertical-apps/va-mmcx-price-api/blob/main/src/constants/slip44.ts
// https://price.api.cx.metamask.io/v2/supportedNetworks
// https://price.api.cx.metamask.io/v3/spot-prices?assetIds=<CAIP-ASSET-ID>&vsCurrency=usd
// Include chain name + native symbol. Keep sorted by chain ID.

Developers can check network support and confirm a specific assetId returns a price before adding a new chain entry.

Checklist

  • Comment-only change; no changelog needed
  • No functional or test changes required
Open in Web Open in Cursor 

cursoragent and others added 2 commits August 14, 2026 09:05
…ation

Add an example Price API v3/spot-prices URL above SPOT_PRICES_SUPPORT_INFO
so developers can verify an assetId is supported before adding a new entry.

Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
@Prithpal-Sooriya
Prithpal-Sooriya marked this pull request as ready for review August 14, 2026 09:11
@Prithpal-Sooriya
Prithpal-Sooriya requested a review from a team as a code owner August 14, 2026 09:11
Comment thread packages/assets-controllers/src/token-prices-service/codefi-v2.ts
Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
export const getNativeTokenAddress = (chainId: Hex): Hex =>
chainIdToNativeTokenAddress[chainId] ?? ZERO_ADDRESS;

// Price API v3/spot-prices chains only — verify support before adding:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd love to have cursor adding PR comments around this

@Prithpal-Sooriya
Prithpal-Sooriya added this pull request to the merge queue Aug 14, 2026
Merged via the queue into main with commit e14029e Aug 14, 2026
63 of 64 checks passed
@Prithpal-Sooriya
Prithpal-Sooriya deleted the cursor/spot-prices-example-url-comment-7706 branch August 14, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants