refactor(account-tree-controller): force use of password for :exportState - #9883
Merged
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
gantunesr
approved these changes
Aug 14, 2026
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
Manually tested, all good. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Forcing consumers to pass the
passwordbefore extracting the account-tree state and the associated secrets.References
Checklist
Note
High Risk
Touches mnemonic/private-key export and adds a breaking API; consumers must pass passwords and register
KeyringController:verifyPassword.Overview
Breaking:
exportStatenow requires a vaultpasswordwheneverincludeSecrets: true.ExportStateOptionsis a discriminated union so TypeScript enforcespasswordwith secrets and forbids it for metadata-only exports.Before reading mnemonics or private keys,
exportStatecallsKeyringController:verifyPassword; wrong passwords propagate as errors. Metadata-only export still only needs an unlocked vault. The controller messenger must allowKeyringController:verifyPassword, and the changelog marks the:import/exportStateaddition as breaking for consumers.Reviewed by Cursor Bugbot for commit 0f21c08. Bugbot is set up for automated code reviews on this repo. Configure here.