fix(enforcers): pin ExactCalldataBatchEnforcer terms target and value - #199
Open
SashaMIT wants to merge 1 commit into
Open
fix(enforcers): pin ExactCalldataBatchEnforcer terms target and value#199SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Terms are Execution[] but beforeHook only compared calldata, so a redeemer could swap targets or attach ETH with identical calldata. Enforce target and value as well; add regression tests. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #198. Sibling of #195 / #197.
ExactCalldataBatchEnforcerterms are encoded asExecution[](target, value, calldata), butbeforeHookonly hashed calldata. A redeemer could reuse the same calldata against a different ERC-20target(or attach nativevalue) while the caveat still passed.ExactExecutionBatchEnforceralready pins the full execution. Single-callExactCalldataEnforcercorrectly treats terms as raw calldata; the batch variant's terms ABI implies target/value must be checked too.Fix
In the batch loop, require
targetandvalueequality with terms, then calldata (fail closed). NatSpec updated.Testing
forge test --match-contract ExactCalldataBatch— 11/11 (includes target-swap + non-zero value regressions).Made with Cursor