test: removed beforeEach usage from fetchNewTransactionsForAccount tests - #113
Merged
Conversation
gabrieledm
force-pushed
the
chore/gabrieledm/tests/reduce-tron-tech-debth_checkAddressActivity
branch
from
August 4, 2026 20:33
e19b83d to
0d760aa
Compare
gabrieledm
force-pushed
the
chore/gabrieledm/tests/reduce-tron-tech-debth_fetchNewTransactionsForAccount
branch
from
August 4, 2026 20:33
6604b5e to
973ac99
Compare
Contributor
Author
|
The ESLint errors |
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> Fourth PR of Stacked pull requests to remove the usage of `beforeEach` and follow the [Unit Testing Guidelines ](https://github.com/MetaMask/contributor-docs/blob/main/docs/testing/unit-testing.md#avoid-the-use-of-beforeeach) in the file `packages/tron-wallet-snap/src/services/transactions/TransactionsService.test.ts`. The base PR is: #110 To split the PRs is used the [Stacked pull requests](https://docs.github.com/en/pull-requests/reference/stacked-pull-requests) feature from GitHub ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [X] I've updated the test suite for new or updated code as appropriate - [X] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
ulissesferreira
approved these changes
Aug 5, 2026
ulissesferreira
merged commit Aug 5, 2026
be97d4e
into
chore/gabrieledm/tests/reduce-tron-tech-debth_checkAddressActivity
16 checks passed
ulissesferreira
deleted the
chore/gabrieledm/tests/reduce-tron-tech-debth_fetchNewTransactionsForAccount
branch
August 5, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Third PR of Stacked pull requests to remove the usage of
beforeEachand follow the Unit Testing Guidelinesin the file
packages/tron-wallet-snap/src/services/transactions/TransactionsService.test.ts.The base PR is: #110
To split the PRs is used the Stacked pull requests feature from GitHub
References
Checklist