feat(tron-wallet-snap): add CoreAssetsAdapter and initialize in AssetsService - #141
Closed
ulissesferreira wants to merge 2 commits into
Closed
feat(tron-wallet-snap): add CoreAssetsAdapter and initialize in AssetsService#141ulissesferreira wants to merge 2 commits into
ulissesferreira wants to merge 2 commits into
Conversation
…sService Introduce CoreAssetsAdapter, mapControllerAsset, and SnapAssetsAdapter DI refactors. Wire adapters in context and store CoreAssetsAdapter on AssetsService without routing reads through Core yet. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
…tAssetsByScope No production caller uses scope-scoped reads through the Snap adapter. CoreAssetsAdapter still uses AssetsProvider.getAccountAssetsByScope internally. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
ulissesferreira
commented
Aug 10, 2026
Contributor
Author
There was a problem hiding this comment.
Correct implementation of the Adapters means they should be initialized outside and passed into the AssetsService
Contributor
Author
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This is the first half of the WPN-1497 core adapter work. It introduces the Core adapter infrastructure without changing runtime asset routing behavior.
CoreAssetsAdapterandmapControllerAssetfor AssetsController integrationSnapAssetsAdapterto acceptConfigProvidervia DI (removes directcontextimport)snapAssetsAdapterandcoreAssetsAdapterincontext.tsAssetsServiceto accept injected adapters and storeCoreAssetsAdapter, but all reads/writes still delegate toSnapAssetsAdapterAssetsService.test.tsunchanged from main (no migration routing assertions)The follow-up PR on
ulissesferreira/wpn-1497-core-adapter-routing-9863adds feature-flagged routing through Core.References
ulissesferreira/wpn-1497-core-adapter-routing-9863Checklist