Skip to content

fix: add test scripts to sample snap#20

Merged
mikesposito merged 2 commits into
mainfrom
me/add-test-scripts-to-sample-snap
Jul 8, 2026
Merged

fix: add test scripts to sample snap#20
mikesposito merged 2 commits into
mainfrom
me/add-test-scripts-to-sample-snap

Conversation

@mikesposito

Copy link
Copy Markdown
Member

Explanation

The following scripts were missing from sample-snap's package.json file:

  • test:clean
  • test:verbose
  • test:watch

This was causing yarn test to call itself recursively, instead of running tests like yarn workspace @metamask/sample-snap test would.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@mikesposito mikesposito requested review from a team as code owners July 8, 2026 12:37
Julink-eth
Julink-eth previously approved these changes Jul 8, 2026
Comment thread yarn.config.cjs

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test scripts requirements have been aligned so that snap and non-snap packages need to follow the same constraints

@mikesposito mikesposito requested a review from Julink-eth July 8, 2026 12:47
@mikesposito mikesposito added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 2d4aa47 Jul 8, 2026
42 checks passed
@mikesposito mikesposito deleted the me/add-test-scripts-to-sample-snap branch July 8, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants