Skip to content

feat(tron-wallet-snap)!: remove assets handlers - #263

Merged
ulissesferreira merged 3 commits into
mainfrom
WPN-2015-remove-asset-handlers
Sep 4, 2026
Merged

feat(tron-wallet-snap)!: remove assets handlers#263
ulissesferreira merged 3 commits into
mainfrom
WPN-2015-remove-asset-handlers

Conversation

@ulissesferreira

Copy link
Copy Markdown
Contributor

Closes WPN-2015

Summary

  • Removes the onAssetsLookup, onAssetsConversion, onAssetHistoricalPrice, and onAssetsMarketData entry points from tron-wallet-snap
  • Removes the now-unused AssetsHandler (src/handlers/assets/)
  • Removes the now-unused endowment:assets permission from the manifest

The AssetsService is kept since it is used by client request, keyring, send, and confirmation services.

Breaking change

The asset handler entry points are no longer exported by the snap.

@ulissesferreira
ulissesferreira requested a review from a team as a code owner September 2, 2026 17:16
@ulissesferreira
ulissesferreira force-pushed the WPN-2015-remove-asset-handlers branch 6 times, most recently from 16f0be9 to 7c894d2 Compare September 4, 2026 09:04
Remove the onAssetsLookup, onAssetsConversion, onAssetHistoricalPrice,
and onAssetsMarketData entry points, along with the now-unused
AssetsHandler and the endowment:assets permission.

Closes WPN-2015
@ulissesferreira
ulissesferreira force-pushed the WPN-2015-remove-asset-handlers branch 2 times, most recently from 961856c to 26754e3 Compare September 4, 2026 09:22
@ulissesferreira
ulissesferreira force-pushed the WPN-2015-remove-asset-handlers branch from 26754e3 to 8f7fc82 Compare September 4, 2026 09:24
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

@ulissesferreira ulissesferreira changed the title feat(tron-wallet-snap)!: remove asset handler entry points feat(tron-wallet-snap)!: remove assets handlers Sep 4, 2026

@mikesposito mikesposito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@ulissesferreira
ulissesferreira added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit 64b83bf Sep 4, 2026
55 checks passed
@ulissesferreira
ulissesferreira deleted the WPN-2015-remove-asset-handlers branch September 4, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants