Enhance JS section #2450
Merged
Enhance JS section #2450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add viem, web3, ethers support
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const tx = await contract.methods.update('NEW_MESSAGE').send({ from: signer.getAddress() }) | ||
|
|
||
| // Wait for transaction to finish | ||
| const receipt = await tx.wait() |
There was a problem hiding this comment.
Bug: Invalid method call on web3 transaction
The code calls tx.wait() on a web3.js transaction, but web3.js transactions don't have a wait() method—that's an ethers.js pattern. In web3.js, the send() method already returns a receipt when the transaction is mined, so this line will throw a TypeError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add viem, web3, ethers support
Description
Issue(s) fixed
Fixes #
Preview
Checklist
External contributor checklist
Note
Restructures EVM SDK docs into new Quickstart and Guides with multi-library (viem/web3.js/ethers/Wagmi) examples, updates sidebar and redirects, fixes links, and relaxes markdown link handling to warnings.
manage-user-accounts,manage-networks,send-transactions/index,send-transactions/batch-transactions,sign-data/index(+siwe),interact-with-contracts, and MetaMask‑exclusivemetamask-exclusive/{batch-requests,use-deeplinks,display-tokens}.evm/connect/guides/javascript/*andevm/connect/guides/wagmi/*; updates quickstarts and tiles insdk/evm/index.provider-apiexamples/links and various intra-doc links.sdk-sidebar.jsto include Quickstart and reorganized Guides.vercel.jsonredirects to new quickstart andmetamask-exclusivepaths.send-transactions/batch-transactionsin multiple versioned guides.markdown.hooks.onBrokenMarkdownLinkstowarnindocusaurus.config.js.Written by Cursor Bugbot for commit 4f51973. This will update automatically on new commits. Configure here.