Feat EVM Structure changes #2538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| <p align="center"> | ||
| <a href="https://metamask-sdk-examples.vercel.app/" target="_blank"> | ||
| <img src={require("../../_assets/network.gif").default} alt="Switch Networks" width="450px" /> | ||
| <img src={require(networkGif).default} alt="Switch Networks" width="450px" /> |
There was a problem hiding this comment.
Bug: Incorrect require() usage with imported module variable
The code imports a gif file as a module variable (e.g., import networkGif from '...') then incorrectly passes that variable to require() like require(networkGif).default. The require() function expects a string path, not an already-imported module. This will cause a runtime error and the images won't display. The fix is to either use the imported variable directly (src={networkGif}) or use require() with a string path.
Additional Locations (1)
shahbaz17
added a commit
that referenced
this pull request
Nov 27, 2025
* Enhance JS section Add viem, web3, ethers support * Feat EVM Structure changes (#2538) * fix some cursor issues and use mm connect package * fix links, slight file restructure * add wagmi tabs + edits * update redirects * fix link --------- Co-authored-by: Alexandra Carrillo <alexandra.carrillo@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue(s) fixed
Fixes #
Preview
Checklist
External contributor checklist
Note
Restructures EVM Connect docs: adds Quickstart section, reorganizes guides (send/sign/interact), updates links/assets and sidebar, and changes markdown broken link handling to warn.
evm/connect/quickstart/*(JavaScript, Wagmi, RainbowKit, ConnectKit, React Native, Dynamic, Embedded Wallets) and updatesdk/evm/indexcards to point to them.Send transactionsandSign data; addevm/connect/guides/interact-with-contracts; consolidate signing intoevm/connect/guides/sign-data/index(+siwe).evm/connect/guides/javascript/interact-with-contracts.mdand JavaScript-specific nested guide structure.sdk-sidebar.jsto reflect new Quickstart and Guides structure; add MetaMask Exclusive group; tidy JSON-RPC category link spacing.../_assets/*), fix batching links inbatch-requestsand Wagmi guides, refresh tables, and example code in provider API reference.docusaurus.config.js, setmarkdown.hooks.onBrokenMarkdownLinksfromthrowtowarn.Written by Cursor Bugbot for commit 4adc574. This will update automatically on new commits. Configure here.