-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: Fix network search gns #31357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
feat: Fix network search gns #31357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Builds ready [a3710fe]
UI Startup Metrics (1224 ± 73 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux
|
Collaborator
Builds ready [24e7344]
UI Startup Metrics (1182 ± 56 ms)
Bundle size diffs
|
vinnyhoward
approved these changes
Apr 1, 2025
Member
Author
|
@mmragkandala since we are using the same network selector in Settings, do we want to remove the network search? |
Member
Author
|
Closing since we are planning to keep the search bar |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to hide search bar in network list menu
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4424
Manual testing steps
Screenshots/Recordings
Before
NA
After
Screen.Recording.2025-03-27.at.8.43.38.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist