Skip to content

Conversation

@NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Mar 27, 2025

This PR is to hide search bar in network list menu

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4424

Manual testing steps

  1. Run extension with REMOVE_GNS=1 yarn start
  2. Start the connections flow, check the connections menu network selector doesn't have search bar

Screenshots/Recordings

Before

NA

After

Screen.Recording.2025-03-27.at.8.43.38.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner March 27, 2025 15:09
@metamaskbot metamaskbot added team-core-extension-ux Core Extension UX team INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [a3710fe]
UI Startup Metrics (1224 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1224112015357312641364
load10779711344671148997
domContentLoaded10719671336661145993
domInteractive17134151630
firstPaint819701343403218990
backgroundConnect11613113910
firstReactRender18134741925
getState10435768
initialActions001001
loadScripts817706107666856897
setupStore7415278
WebpackHomeuiStartup952849109659971985
load81971293857857908
domContentLoaded81370893456849901
domInteractive16125991442
firstPaint4865493834284894
backgroundConnect15112741525
firstReactRender13121811414
getState6311278
initialActions001001
loadScripts81170793255847891
setupStore7519289
FirefoxBrowserifyHomeuiStartup13561191193914713871732
load12151068179813712471581
domContentLoaded12151068179813712471581
domInteractive11140232347597
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2516205202442
firstReactRender23195762433
getState8474978
initialActions001001
loadScripts11911050177713112201504
setupStore6416267
WebpackHomeuiStartup10128641544130921969
load8827521356116840935
domContentLoaded8827511355116840934
domInteractive112352443217596
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21156072532
firstReactRender20182922026
getState9546589
initialActions002001
loadScripts8637341326113826962
setupStore8562789
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -565.57 KiB (-8.71%)
  • ui: -988.65 KiB (-12.75%)
  • common: -983.11 KiB (-9.57%)

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/components/multichain/network-list-menu/network-list-menu.tsx

@metamaskbot
Copy link
Collaborator

Builds ready [24e7344]
UI Startup Metrics (1182 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1182106214385612151278
load1029938125051953994
domContentLoaded1023934124551949991
domInteractive16133441626
firstPaint7801281249384249985
backgroundConnect1161471599
firstReactRender19133941932
getState11429768
initialActions001000
loadScripts806706101551837889
setupStore7515278
WebpackHomeuiStartup910821114978926950
load77158990264813876
domContentLoaded76557089663809866
domInteractive15114371334
firstPaint42254869327807849
backgroundConnect15114571438
firstReactRender14123141326
getState6321268
initialActions001001
loadScripts76356089563808856
setupStore7414278
FirefoxBrowserifyHomeuiStartup13671207190813914221742
load12321066174713412841578
domContentLoaded12321066174713412841578
domInteractive9635158278897
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2417112112538
firstReactRender22193532327
getState6417279
initialActions001001
loadScripts12091047171913212621552
setupStore6436467
WebpackHomeuiStartup9848411576151906983
load8627311336136814902
domContentLoaded8617311335136814901
domInteractive113382102614894
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2013114122232
firstReactRender19162821924
getState8463678
initialActions001001
loadScripts8457181313132805941
setupStore8546578
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@NidhiKJha
Copy link
Member Author

@mmragkandala since we are using the same network selector in Settings, do we want to remove the network search?

@NidhiKJha
Copy link
Member Author

Closing since we are planning to keep the search bar

@NidhiKJha NidhiKJha closed this Apr 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants