fix: cp-12.15.0 remove sentry cdn url from sentry script

[davidmurdoch]

We don't use this code path, but just having this url appear in our extension bundle makes it looks like we could load code from an external source, something which is not permitted by extension web stores.

To test: download the build (or build it yourself), extract it, search the source the code for browser.sentry-cdn.com. It should not exist.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [229596f]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1233 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1233	1123	1437	65	1284	1340
			load	1085	980	1214	61	1152	990
			domContentLoaded	1079	974	1210	60	1144	982
			domInteractive	17	13	73	9	17	30
			firstPaint	773	127	1236	421	225	307
			backgroundConnect	10	5	52	5	9	10
			firstReactRender	20	14	52	6	21	34
			getState	11	4	31	6	6	8
			initialActions	0	0	2	0	0	0
			loadScripts	824	695	939	61	872	935
			setupStore	8	5	21	2	7	8
	Webpack	Home	uiStartup	934	817	1149	58	958	981
			load	801	607	983	63	841	880
			domContentLoaded	796	601	977	62	835	872
			domInteractive	15	12	35	6	13	32
			firstPaint	461	55	913	324	794	851
			backgroundConnect	15	11	34	4	15	25
			firstReactRender	13	12	24	1	13	15
			getState	6	3	14	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	794	591	967	62	832	862
			setupStore	7	5	10	1	8	9
Firefox	Browserify	Home	uiStartup	1357	1169	1865	141	1393	1725
			load	1219	1023	1678	134	1258	1577
			domContentLoaded	1219	1023	1677	134	1258	1576
			domInteractive	103	39	222	31	88	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	55	7	24	36
			firstReactRender	23	19	63	6	24	28
			getState	6	3	25	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1197	1005	1650	131	1236	1542
			setupStore	6	3	34	3	6	7
	Webpack	Home	uiStartup	1011	866	1604	161	920	975
			load	881	749	1460	147	818	878
			domContentLoaded	881	748	1459	147	816	878
			domInteractive	111	32	180	27	153	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	56	7	25	33
			firstReactRender	20	17	36	3	20	26
			getState	11	4	60	11	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	863	733	1427	144	803	891
			setupStore	8	5	37	4	8	9

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: -34 Bytes (0%)

[metamaskbot]

Builds ready [89d36cc]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1207 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1073	1524	68	1247	1318
			load	1068	936	1380	66	1164	993
			domContentLoaded	1062	932	1377	66	1170	989
			domInteractive	16	12	69	7	15	28
			firstPaint	834	164	1219	388	235	989
			backgroundConnect	9	6	45	4	9	9
			firstReactRender	18	15	35	3	18	25
			getState	10	4	28	6	6	7
			initialActions	0	0	1	0	0	1
			loadScripts	810	678	1124	66	849	902
			setupStore	7	4	13	2	7	8
	Webpack	Home	uiStartup	928	816	1081	52	953	984
			load	796	583	912	63	834	869
			domContentLoaded	790	576	906	63	828	865
			domInteractive	15	11	40	6	13	32
			firstPaint	506	56	907	330	824	858
			backgroundConnect	15	10	34	5	15	26
			firstReactRender	13	12	24	2	13	16
			getState	6	3	14	2	7	7
			initialActions	0	0	1	0	0	1
			loadScripts	788	566	893	64	827	864
			setupStore	7	5	10	1	8	9
Firefox	Browserify	Home	uiStartup	1373	1195	1908	139	1403	1735
			load	1230	1069	1761	135	1264	1564
			domContentLoaded	1229	1069	1761	135	1263	1564
			domInteractive	100	40	235	27	85	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	17	145	16	27	51
			firstReactRender	24	19	58	8	25	53
			getState	7	3	43	5	7	9
			initialActions	0	0	2	0	0	1
			loadScripts	1204	1053	1740	135	1238	1536
			setupStore	6	4	33	3	6	8
	Webpack	Home	uiStartup	987	849	1520	165	905	983
			load	864	743	1325	146	802	881
			domContentLoaded	864	742	1325	146	802	880
			domInteractive	111	36	208	26	160	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	97	12	21	35
			firstReactRender	19	16	28	2	19	23
			getState	9	4	65	10	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	847	726	1305	142	789	862
			setupStore	8	5	64	8	7	8

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0%)
• ui: 70 Bytes (0%)
• common: -1.58 KiB (-0.02%)

[metamaskbot]

Builds ready [74e9220]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1192 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1075	1334	60	1239	1290
			load	1039	942	1178	53	1142	982
			domContentLoaded	1033	938	1173	53	942	995
			domInteractive	16	13	30	4	16	28
			firstPaint	774	95	1177	388	250	976
			backgroundConnect	10	7	53	6	9	10
			firstReactRender	20	14	56	8	20	43
			getState	11	4	31	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	820	708	963	53	864	904
			setupStore	8	5	27	3	7	8
	Webpack	Home	uiStartup	952	786	1242	76	960	987
			load	809	599	951	64	841	907
			domContentLoaded	803	586	942	65	834	901
			domInteractive	15	12	36	6	14	34
			firstPaint	508	58	919	339	827	863
			backgroundConnect	16	11	48	8	14	40
			firstReactRender	14	12	36	4	13	25
			getState	7	4	28	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	801	576	932	65	833	889
			setupStore	7	4	16	2	8	9
Firefox	Browserify	Home	uiStartup	1357	1171	1777	123	1409	1663
			load	1221	1059	1629	118	1265	1503
			domContentLoaded	1221	1058	1629	118	1264	1503
			domInteractive	98	39	196	30	87	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	17	49	6	27	37
			firstReactRender	22	19	46	4	23	29
			getState	7	4	37	5	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1199	1042	1591	117	1245	1475
			setupStore	6	4	12	2	6	7
	Webpack	Home	uiStartup	997	857	1650	181	895	962
			load	873	733	1418	158	814	958
			domContentLoaded	873	733	1417	158	814	958
			domInteractive	115	37	206	25	136	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	112	13	25	34
			firstReactRender	19	16	34	3	19	25
			getState	10	4	83	14	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	856	721	1383	154	800	950
			setupStore	7	5	31	3	7	8

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: -1.58 KiB (-0.02%)

[Gudahtt]

Patch looks correct to me! I haven't tested yet though, someone should do that before we merge this.