Skip to content

Conversation

@hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Mar 27, 2025

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? The comment can look a little cluttered with a lot of files, repetition of file paths.
  2. What is the improvement/solution? Make sections collapsable and change from list to tree structure. Also added file count next to the teams and lines of code changes.

Before

Screenshot 2025-03-27 at 7 45 25 PM

After

Screen.Recording.2025-03-27.at.10.06.04.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Mar 27, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 27, 2025
@hmalik88 hmalik88 removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 28, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 28, 2025
@hmalik88 hmalik88 marked this pull request as ready for review March 28, 2025 02:08
@hmalik88 hmalik88 added team-extension-platform Extension Platform team and removed INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) labels Mar 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [5ea6fd4]
UI Startup Metrics (1175 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1175107214036112111282
load1023927122557956994
domContentLoaded1017923122157968997
domInteractive16133041527
firstPaint7351301230388284989
backgroundConnect106555910
firstReactRender19143641931
getState11449867
initialActions001001
loadScripts807719100456852884
setupStore7513279
WebpackHomeuiStartup953787119581962984
load81161893463851896
domContentLoaded80559693063842885
domInteractive16124171437
firstPaint47253891346840887
backgroundConnect16115281538
firstReactRender14122941426
getState7415278
initialActions001000
loadScripts80258692963841877
setupStore7515288
FirefoxBrowserifyHomeuiStartup13621180188414313871756
load12241058173713512481604
domContentLoaded12231057173613512471604
domInteractive9933199278998
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2517115132550
firstReactRender22195242326
getState7336578
initialActions001001
loadScripts11991040170013312211580
setupStore6318367
WebpackHomeuiStartup9778321520163891974
load8587311326145803894
domContentLoaded8577301325145803894
domInteractive112361602315597
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211390112435
firstReactRender18162521824
getState947912749
initialActions001001
loadScripts8417171306142788881
setupStore8546678
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Mar 28, 2025
HowardBraham
HowardBraham previously approved these changes Mar 28, 2025
@metamaskbot metamaskbot added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label May 16, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [db6d06b]
UI Startup Metrics (1207 ± 77 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1207108015177712511358
load104893213447110961144
domContentLoaded104292713387110911140
domInteractive16132531623
firstPaint724117126341310801116
backgroundConnect74233811
firstReactRender19153852034
getState1354381926
initialActions001001
loadScripts806693104867854910
setupStore85192813
WebpackHomeuiStartup21241731254115222172329
load16311236205612717031820
domContentLoaded16241230205212716991812
domInteractive14115781238
firstPaint1576435763176314
backgroundConnect279116153151
firstReactRender1454138594250316
getState1243571528
initialActions316145
loadScripts16191227205012816981810
setupStore206327351928
FirefoxBrowserifyHomeuiStartup13421167181111813831582
load11881043155510212391419
domContentLoaded11881043155510212391418
domInteractive1073926339124186
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2214125152133
firstReactRender23205572349
getState12537838823
initialActions001001
loadScripts11681029154010012231401
setupStore6435468
WebpackHomeuiStartup15081350181310615721728
load1286117015679713211510
domContentLoaded1286117015679713211510
domInteractive80581391884125
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2414254242442
firstReactRender34294743544
getState11522722929
initialActions002111
loadScripts1265115315539413051449
setupStore85577812
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 0ms
Sum of all benchmark exceeds: 2ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 23, 2025
@HowardBraham HowardBraham added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit 2b69dfa May 23, 2025
157 of 158 checks passed
@HowardBraham HowardBraham deleted the hm/codeowners-comment-v2 branch May 23, 2025 19:26
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2025
@metamaskbot metamaskbot added the release-12.21.0 Issue or pull request that will be included in release 12.21.0 label May 23, 2025
@naugtur
Copy link
Contributor

naugtur commented Jun 23, 2025

The policy review process message got hidden and slightly broken.
I started getting pings for review again.
fix here #33828

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.21.0 Issue or pull request that will be included in release 12.21.0 team-extension-platform Extension Platform team team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants