Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Mar 28, 2025

Description

Bump @metamask/transaction-controller to pad chain IDs when validating signature.

Open in GitHub Codespaces

Related issues

Fixes: #31338

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Mar 28, 2025
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/transaction-controller@52.2.052.2.0-preview-ed8163d None 0 0 B

View full report↗︎

matthewwalsh0 added a commit that referenced this pull request Mar 28, 2025
…chain ID (#31389) (#31390)

## **Description**

Cherry-pick of #31389 for `12.15.0`.

Using patch due to unrelated changes in latest
`@metamask/transaction-controller` version.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31390?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot
Copy link
Collaborator

Builds ready [fa57037]
UI Startup Metrics (1178 ± 54 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1178107514015412031266
load1028933126353934982
domContentLoaded1022927125954937986
domInteractive16133141525
firstPaint736701155400239975
backgroundConnect11614214910
firstReactRender20146771931
getState10428667
initialActions001001
loadScripts811703104654835888
setupStore7424379
WebpackHomeuiStartup943678121675965977
load80054492072842881
domContentLoaded79353991473836868
domInteractive15124171438
firstPaint50761918340834869
backgroundConnect16115291539
firstReactRender14123641324
getState7413278
initialActions001000
loadScripts79153891273835858
setupStore7412179
FirefoxBrowserifyHomeuiStartup13751205192815013971760
load12371074176014112661583
domContentLoaded12371073176014112661583
domInteractive10142202278997
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23169492439
firstReactRender22193532528
getState7431378
initialActions001001
loadScripts12151057172513812431556
setupStore6320267
WebpackHomeuiStartup9828401510137901964
load8587251363120849989
domContentLoaded8587251363120849989
domInteractive114352032814898
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21147692439
firstReactRender19164131923
getState8451689
initialActions001001
loadScripts8417091348118838975
setupStore84751079
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 990 Bytes (0.01%)

@matthewwalsh0
Copy link
Member Author

Transaction controller bumped to 52.3.0 in #31335

@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot use type-4 transactions on chains with odd length hex ID

3 participants