refactor: remove network #31394

gantunesr · 2025-03-28T13:17:50Z

Description

This ticket refactors the logic to remove EVM networks from the network picker

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/868

Manual testing steps

Select an EVM network that is not Ethereum, e.g., Linea, Polygon, BSC
Change the selected network to Solana
Delete the previous EVM selected network
The network should be removed and when selecting an EVM account, the network should automatically change to Ethereum mainnet

Screenshots/Recordings

Not applicable

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…into gar/refactor/remove-network

metamaskbot · 2025-04-22T13:16:50Z

Builds ready [7be5540]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1211 ± 74 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1211	1068	1624	74	1255	1321
			load	1048	928	1347	68	1074	1173
			domContentLoaded	1041	902	1337	68	1069	1164
			domInteractive	18	13	62	9	17	29
			firstPaint	681	83	1193	424	1062	1152
			backgroundConnect	8	4	85	9	8	15
			firstReactRender	20	14	43	5	21	33
			getState	14	5	171	18	18	28
			initialActions	0	0	1	0	0	1
			loadScripts	805	658	1063	65	832	919
			setupStore	7	5	15	2	8	13
	Webpack	Home	uiStartup	2082	1696	2553	176	2219	2332
			load	1610	1320	1954	127	1713	1821
			domContentLoaded	1604	1316	1931	125	1707	1816
			domInteractive	15	11	55	8	13	37
			firstPaint	189	63	566	76	239	325
			backgroundConnect	24	10	68	12	27	53
			firstReactRender	204	55	401	123	340	354
			getState	10	3	44	6	12	22
			initialActions	3	1	6	1	3	5
			loadScripts	1599	1314	1907	124	1704	1803
			setupStore	21	6	319	38	20	31
Firefox	Browserify	Home	uiStartup	1382	1190	1671	117	1454	1597
			load	1227	1033	1517	120	1309	1448
			domContentLoaded	1227	1033	1517	120	1309	1448
			domInteractive	102	37	244	34	119	162
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	12	106	14	23	44
			firstReactRender	24	19	54	5	24	30
			getState	8	4	43	6	8	18
			initialActions	0	0	1	0	0	1
			loadScripts	1207	1018	1494	121	1288	1432
			setupStore	6	4	19	2	6	8
	Webpack	Home	uiStartup	1617	1376	2216	169	1704	2011
			load	1379	1174	1985	160	1449	1735
			domContentLoaded	1379	1173	1984	160	1449	1735
			domInteractive	90	36	383	41	100	156
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	105	15	24	42
			firstReactRender	37	31	64	5	39	46
			getState	10	4	33	5	10	24
			initialActions	1	0	2	1	1	1
			loadScripts	1356	1154	1884	155	1429	1716
			setupStore	10	5	50	8	9	23

cc: @HowardBraham
Benchmark value 1618 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 2011 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1735 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1735 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1716 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 3ms | Sum of p95 exceeds: 312ms
Sum of all benchmark exceeds: 315ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 142 Bytes (0%)
ui: -417 Bytes (-0.01%)
common: 0 Bytes (0%)

ccharly

LGTM + tested, just a left nit suggestion.

ui/components/app/modals/confirm-delete-network/confirm-delete-network.component.js

…-delete-network.component.js Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ui/components/app/modals/confirm-delete-network/confirm-delete-network.component.js

…-delete-network.component.js Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

metamaskbot · 2025-04-22T19:03:20Z

Builds ready [3b432a0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1244 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1244	1098	1446	64	1271	1384
			load	1073	960	1255	60	1102	1193
			domContentLoaded	1066	955	1248	60	1094	1184
			domInteractive	18	14	66	7	17	29
			firstPaint	592	137	1255	425	1066	1153
			backgroundConnect	8	4	28	4	8	14
			firstReactRender	22	16	50	6	23	39
			getState	14	5	40	9	20	33
			initialActions	0	0	1	0	0	1
			loadScripts	826	729	996	56	853	932
			setupStore	8	5	14	2	8	13
	Webpack	Home	uiStartup	2185	1749	2669	176	2315	2409
			load	1686	1371	2073	133	1772	1872
			domContentLoaded	1678	1367	2061	131	1766	1861
			domInteractive	16	12	58	9	14	40
			firstPaint	189	69	503	69	225	329
			backgroundConnect	27	10	87	16	30	66
			firstReactRender	216	55	370	119	337	360
			getState	15	4	197	21	16	32
			initialActions	3	1	7	1	4	6
			loadScripts	1674	1366	2037	130	1762	1853
			setupStore	26	7	293	46	22	44
Firefox	Browserify	Home	uiStartup	1347	1178	1827	110	1401	1570
			load	1204	1049	1704	116	1267	1446
			domContentLoaded	1204	1049	1703	116	1266	1446
			domInteractive	104	37	257	33	118	162
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	12	222	25	19	44
			firstReactRender	22	19	51	5	22	26
			getState	7	4	26	3	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1183	1027	1681	119	1249	1431
			setupStore	5	4	24	3	6	6
	Webpack	Home	uiStartup	1499	1327	1950	124	1593	1725
			load	1280	1129	1681	112	1363	1473
			domContentLoaded	1280	1129	1681	112	1363	1473
			domInteractive	84	47	310	32	89	143
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	57	6	22	33
			firstReactRender	35	29	48	4	36	44
			getState	8	4	33	5	9	20
			initialActions	0	0	2	1	1	1
			loadScripts	1261	1114	1661	112	1343	1453
			setupStore	10	5	68	9	8	31

cc: @HowardBraham
Benchmark value 1244 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1074 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1067 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1384 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1194 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 20ms | Sum of p95 exceeds: 30ms
Sum of all benchmark exceeds: 50ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 142 Bytes (0%)
ui: -417 Bytes (-0.01%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-23T14:14:59Z

Builds ready [97de83d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1210 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1210	1076	1574	75	1247	1323
			load	1047	954	1362	68	1082	1160
			domContentLoaded	1041	948	1351	67	1074	1153
			domInteractive	17	13	62	7	16	28
			firstPaint	708	79	1362	422	1059	1160
			backgroundConnect	7	4	17	2	7	10
			firstReactRender	20	16	48	5	21	31
			getState	13	5	35	8	19	27
			initialActions	0	0	1	0	0	1
			loadScripts	804	702	1077	61	834	913
			setupStore	8	5	19	3	9	15
	Webpack	Home	uiStartup	2082	1692	2540	189	2197	2354
			load	1620	1319	1978	147	1721	1880
			domContentLoaded	1614	1315	1968	146	1716	1872
			domInteractive	15	11	54	9	14	43
			firstPaint	175	63	368	63	216	304
			backgroundConnect	28	9	284	37	27	68
			firstReactRender	189	55	401	125	335	371
			getState	11	4	30	6	14	23
			initialActions	3	1	7	1	3	5
			loadScripts	1610	1313	1944	145	1714	1868
			setupStore	17	6	185	18	20	38
Firefox	Browserify	Home	uiStartup	1354	1188	1700	107	1401	1558
			load	1207	1020	1532	112	1271	1404
			domContentLoaded	1207	1020	1532	112	1271	1404
			domInteractive	106	40	210	34	123	183
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	89	13	21	63
			firstReactRender	22	19	50	4	23	27
			getState	7	4	18	2	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1187	1006	1517	110	1252	1392
			setupStore	5	4	13	1	6	7
	Webpack	Home	uiStartup	1506	1335	2053	123	1573	1752
			load	1291	1147	1768	105	1330	1504
			domContentLoaded	1291	1147	1768	105	1330	1504
			domInteractive	82	39	156	23	94	137
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	73	7	23	30
			firstReactRender	34	29	67	5	36	40
			getState	9	4	42	7	9	28
			initialActions	1	0	2	1	1	1
			loadScripts	1271	1130	1750	104	1309	1476
			setupStore	8	5	30	4	8	19

Benchmark value 371 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 1ms
Sum of all benchmark exceeds: 1ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 142 Bytes (0%)
ui: -417 Bytes (-0.01%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-24T01:18:55Z

Builds ready [1647a88]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1207 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1066	1406	58	1246	1316
			load	1044	945	1206	53	1075	1150
			domContentLoaded	1039	941	1197	53	1070	1144
			domInteractive	17	13	62	6	17	28
			firstPaint	763	163	1205	394	1059	1116
			backgroundConnect	7	4	14	2	7	9
			firstReactRender	21	16	48	5	21	33
			getState	12	5	31	7	17	26
			initialActions	0	0	3	0	0	1
			loadScripts	802	699	942	52	833	908
			setupStore	8	4	16	2	8	14
	Webpack	Home	uiStartup	2109	1710	2526	167	2219	2351
			load	1630	1318	1941	130	1732	1824
			domContentLoaded	1623	1314	1918	129	1727	1814
			domInteractive	15	11	59	10	13	42
			firstPaint	176	64	327	62	206	299
			backgroundConnect	24	9	67	12	27	56
			firstReactRender	210	54	408	121	334	358
			getState	14	4	300	30	13	30
			initialActions	3	1	6	1	3	4
			loadScripts	1619	1311	1895	128	1725	1796
			setupStore	21	6	301	39	19	32
Firefox	Browserify	Home	uiStartup	1361	1210	1617	93	1410	1551
			load	1213	1036	1495	100	1275	1401
			domContentLoaded	1212	1036	1495	100	1274	1401
			domInteractive	102	40	226	30	116	156
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	178	20	22	48
			firstReactRender	24	19	57	7	24	51
			getState	8	4	34	5	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1191	1018	1475	99	1255	1376
			setupStore	7	4	37	5	6	8
	Webpack	Home	uiStartup	1497	1326	1811	108	1559	1716
			load	1283	1140	1538	98	1354	1486
			domContentLoaded	1283	1139	1537	98	1353	1485
			domInteractive	81	37	148	20	89	128
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	56	7	21	41
			firstReactRender	35	29	55	5	37	45
			getState	8	4	29	4	9	18
			initialActions	0	0	2	1	1	1
			loadScripts	1265	1125	1520	98	1337	1464
			setupStore	9	5	51	7	8	29

Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 1ms
Sum of all benchmark exceeds: 1ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 142 Bytes (0%)
ui: -417 Bytes (-0.01%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-24T22:27:47Z

Builds ready [07e847c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1177 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1177	1067	1493	57	1207	1262
			load	1019	900	1350	56	1051	1094
			domContentLoaded	1013	894	1346	56	1046	1085
			domInteractive	17	13	51	5	16	28
			firstPaint	648	82	1351	408	1025	1083
			backgroundConnect	6	4	17	2	7	10
			firstReactRender	21	15	59	7	21	37
			getState	13	5	57	9	17	29
			initialActions	0	0	1	0	0	1
			loadScripts	778	673	1111	55	808	844
			setupStore	7	4	19	3	8	12
	Webpack	Home	uiStartup	2052	1671	2577	181	2197	2274
			load	1581	1313	1948	131	1683	1751
			domContentLoaded	1575	1310	1921	130	1677	1743
			domInteractive	16	11	57	11	12	49
			firstPaint	175	70	405	62	208	310
			backgroundConnect	23	9	96	14	26	55
			firstReactRender	191	55	358	119	339	354
			getState	11	4	166	16	11	23
			initialActions	3	1	7	1	3	4
			loadScripts	1570	1308	1898	129	1674	1740
			setupStore	16	7	40	6	19	29
Firefox	Browserify	Home	uiStartup	1346	1152	1808	122	1404	1593
			load	1202	1030	1680	125	1265	1432
			domContentLoaded	1202	1030	1680	125	1265	1432
			domInteractive	106	42	228	33	122	173
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	63	9	22	38
			firstReactRender	22	19	54	6	22	28
			getState	9	4	185	18	8	13
			initialActions	0	0	1	0	0	1
			loadScripts	1183	1016	1662	125	1249	1418
			setupStore	6	4	50	6	6	9
	Webpack	Home	uiStartup	1493	1304	1849	114	1577	1671
			load	1282	1137	1615	101	1359	1449
			domContentLoaded	1282	1137	1614	101	1359	1449
			domInteractive	85	35	375	35	96	125
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	41	5	22	34
			firstReactRender	34	29	45	3	36	40
			getState	8	4	41	4	8	11
			initialActions	1	0	2	1	1	1
			loadScripts	1263	1122	1595	100	1336	1433
			setupStore	8	5	34	4	8	12

metamaskbot · 2025-04-24T23:39:36Z

Builds ready [e2f110b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1173 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1173	1062	1382	63	1207	1313
			load	1014	905	1178	56	1041	1130
			domContentLoaded	1008	898	1173	55	1037	1124
			domInteractive	17	12	49	5	17	27
			firstPaint	674	70	1180	402	1026	1117
			backgroundConnect	6	4	25	3	7	8
			firstReactRender	21	15	49	7	23	38
			getState	12	5	30	7	17	27
			initialActions	0	0	1	0	0	0
			loadScripts	775	657	917	53	804	894
			setupStore	9	4	127	12	8	13
	Webpack	Home	uiStartup	2048	1678	2547	165	2136	2301
			load	1595	1313	1988	120	1692	1780
			domContentLoaded	1588	1310	1964	120	1688	1774
			domInteractive	15	10	51	9	13	41
			firstPaint	191	83	395	60	245	295
			backgroundConnect	22	9	75	13	24	58
			firstReactRender	211	55	370	129	345	358
			getState	9	3	39	5	11	18
			initialActions	3	1	6	1	3	4
			loadScripts	1584	1308	1940	120	1686	1771
			setupStore	17	6	290	28	17	30
Firefox	Browserify	Home	uiStartup	1400	1141	1842	156	1494	1719
			load	1241	1017	1651	148	1335	1547
			domContentLoaded	1241	1017	1651	148	1335	1546
			domInteractive	105	38	240	34	122	175
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	13	129	18	25	55
			firstReactRender	24	19	57	7	24	37
			getState	8	4	37	5	8	16
			initialActions	0	0	1	0	0	1
			loadScripts	1219	1002	1589	147	1307	1519
			setupStore	10	4	199	26	7	13
	Webpack	Home	uiStartup	1505	1365	1775	98	1587	1689
			load	1292	1153	1573	93	1360	1466
			domContentLoaded	1292	1153	1573	93	1360	1466
			domInteractive	82	37	273	27	88	130
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	104	11	22	38
			firstReactRender	35	29	59	5	36	45
			getState	8	4	31	5	9	24
			initialActions	0	0	1	0	1	1
			loadScripts	1271	1137	1556	92	1335	1447
			setupStore	8	5	43	5	8	10

cc: @HowardBraham
Benchmark value 1242 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1719 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1547 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1546 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1519 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 206ms
Sum of all benchmark exceeds: 210ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 142 Bytes (0%)
ui: -417 Bytes (-0.01%)
common: 0 Bytes (0%)

gantunesr added 5 commits March 27, 2025 23:33

refactor: remove account

d22ca21

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

36e66e2

…into gar/refactor/remove-network

chore: update yarn

d8d3298

chore: update yarn file

39ce887

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

0bd3486

…into gar/refactor/remove-network

metamaskbot added the team-accounts-framework Accounts Framework team label Apr 17, 2025

gantunesr marked this pull request as ready for review April 17, 2025 01:54

Merge branch 'main' into gar/refactor/remove-network

8e7c4ef

gantunesr added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 17, 2025

gantunesr added 4 commits April 21, 2025 16:01

Merge branch 'main' into gar/refactor/remove-network

6a67e2d

fix: remove network via multichain-network-controller

957ec56

Merge branch 'main' into gar/refactor/remove-network

d80b26e

Merge branch 'main' into gar/refactor/remove-network

7be5540

test: fix failing unit test

0176026

ccharly previously approved these changes Apr 22, 2025

View reviewed changes

ui/components/app/modals/confirm-delete-network/confirm-delete-network.component.js Show resolved Hide resolved

chore: update ui/components/app/modals/confirm-delete-network/confirm…

1293ee4

…-delete-network.component.js Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

gantunesr dismissed ccharly’s stale review via 1293ee4 April 22, 2025 15:19

ccharly reviewed Apr 22, 2025

View reviewed changes

ui/components/app/modals/confirm-delete-network/confirm-delete-network.component.js Outdated Show resolved Hide resolved

chore: update ui/components/app/modals/confirm-delete-network/confirm…

82e1357

…-delete-network.component.js Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ccharly previously approved these changes Apr 22, 2025

View reviewed changes

Merge branch 'main' into gar/refactor/remove-network

3b432a0

owencraston previously approved these changes Apr 22, 2025

View reviewed changes

gantunesr enabled auto-merge April 22, 2025 23:13

Merge branch 'main' into gar/refactor/remove-network

97de83d

gantunesr added this pull request to the merge queue Apr 23, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2025

gantunesr added this pull request to the merge queue Apr 23, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2025

gantunesr added this pull request to the merge queue Apr 23, 2025

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 23, 2025

Merge branch 'main' into gar/refactor/remove-network

1647a88

gantunesr dismissed stale reviews from ccharly and owencraston via 1647a88 April 24, 2025 00:41

ccharly approved these changes Apr 24, 2025

View reviewed changes

Merge branch 'main' into gar/refactor/remove-network

6787867

owencraston approved these changes Apr 24, 2025

View reviewed changes

Merge branch 'main' into gar/refactor/remove-network

07e847c

Merge branch 'main' into gar/refactor/remove-network

e2f110b

gantunesr enabled auto-merge April 24, 2025 23:27

gantunesr added this pull request to the merge queue Apr 24, 2025

Merged via the queue into main with commit fcb7c3b Apr 25, 2025
169 checks passed

gantunesr deleted the gar/refactor/remove-network branch April 25, 2025 00:11

github-actions bot locked and limited conversation to collaborators Apr 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: remove network #31394

refactor: remove network #31394

Uh oh!

gantunesr commented Mar 28, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 22, 2025

Uh oh!

ccharly left a comment

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Apr 22, 2025

Uh oh!

metamaskbot commented Apr 23, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Apr 24, 2025

Uh oh!

metamaskbot commented Apr 24, 2025

Uh oh!

metamaskbot commented Apr 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

refactor: remove network #31394

refactor: remove network #31394

Uh oh!

Conversation

gantunesr commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Apr 22, 2025

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Apr 22, 2025

Uh oh!

metamaskbot commented Apr 23, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Apr 24, 2025

Uh oh!

metamaskbot commented Apr 24, 2025

Uh oh!

metamaskbot commented Apr 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gantunesr commented Mar 28, 2025 •

edited

Loading