-
Notifications
You must be signed in to change notification settings - Fork 5.5k
test: migrate NFT tests to Typescript and Page object modal #31396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [ac785a6]
UI Startup Metrics (1192 ± 57 ms)
Bundle size diffs
|
seaona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good! Just a small nit, let me know what you think 🙏
Builds ready [3fa4d00]
UI Startup Metrics (1186 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM awesome work!!
Description
Create base methods, and migrate following nft e2e tests files to Typescript and Page object modal.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-344 and https://consensyssoftware.atlassian.net/browse/MMQA-350
Manual testing steps
Tests should pass and be robust
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist