Skip to content

Conversation

@chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Mar 28, 2025

Description

Create base methods, and migrate following nft e2e tests files to Typescript and Page object modal.

test/e2e/tests/tokens/nft/import-erc1155.spec.js
test/e2e/tests/tokens/nft/remove-erc1155.spec.js
test/e2e/tests/tokens/nft/remove-nft.spec.js 
test/e2e/tests/tokens/nft/view-erc1155-details.spec.js
test/e2e/tests/tokens/nft/view-nft-details.spec.js

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-344 and https://consensyssoftware.atlassian.net/browse/MMQA-350

Manual testing steps

Tests should pass and be robust

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue self-assigned this Mar 28, 2025
@chloeYue chloeYue requested a review from a team as a code owner March 28, 2025 13:28
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Mar 28, 2025
@chloeYue chloeYue marked this pull request as draft March 28, 2025 13:31
@chloeYue chloeYue changed the title test: migrate tests test: migrate NFT tests to Typescript and Page object modal Mar 28, 2025
@chloeYue chloeYue requested review from a team and removed request for a team March 28, 2025 13:57
@MetaMask MetaMask deleted a comment from metamaskbot Mar 28, 2025
@chloeYue chloeYue marked this pull request as ready for review March 28, 2025 14:23
@metamaskbot
Copy link
Collaborator

Builds ready [ac785a6]
UI Startup Metrics (1192 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1192107413605712291293
load1037943117953943993
domContentLoaded1031939117452950994
domInteractive16133341627
firstPaint7971301182378256993
backgroundConnect106515910
firstReactRender19153841926
getState10428668
initialActions001000
loadScripts81773095851853910
setupStore7514278
WebpackHomeuiStartup991856128286983997
load84671595854870940
domContentLoaded84071195053867927
domInteractive16125581437
firstPaint55159953350855896
backgroundConnect17114381540
firstReactRender14124151428
getState7415278
initialActions001001
loadScripts83771094952863917
setupStore8516289
FirefoxBrowserifyHomeuiStartup14211218197916114551784
load12761094181415613261657
domContentLoaded12761094181415613261657
domInteractive10440173298898
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect25175362835
firstReactRender23194032529
getState7443479
initialActions002001
loadScripts12521073178915513061636
setupStore7424367
WebpackHomeuiStartup9768321264126893977
load8567231112112830958
domContentLoaded8557231112112829957
domInteractive116342313118097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19134362031
firstReactRender18162921824
getState8455689
initialActions002001
loadScripts8387111085108840977
setupStore8551778
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Copy link
Member

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good! Just a small nit, let me know what you think 🙏

@metamaskbot
Copy link
Collaborator

Builds ready [3fa4d00]
UI Startup Metrics (1186 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1186104714016412181334
load10389321241611241979
domContentLoaded1032917123761917983
domInteractive16133751629
firstPaint7771291243389231972
backgroundConnect96343910
firstReactRender18144741923
getState11433769
initialActions001001
loadScripts818709102860835911
setupStore7522278
WebpackHomeuiStartup963772131384962988
load82164992854849897
domContentLoaded81564591853844886
domInteractive16124481438
firstPaint54157888335835859
backgroundConnect16114071537
firstReactRender14123341327
getState6413278
initialActions001001
loadScripts81264490752843883
setupStore7516279
FirefoxBrowserifyHomeuiStartup13931190202116414291850
load12531064186015712851681
domContentLoaded12531064185915712851681
domInteractive10239185249197
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241675102544
firstReactRender23195242429
getState649178
initialActions001001
loadScripts12301048183715612631657
setupStore6417267
WebpackHomeuiStartup9878381667179908982
load8687311526165812927
domContentLoaded8677301525165812926
domInteractive112391752517396
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2014132122130
firstReactRender18162921923
getState104741379
initialActions001001
loadScripts8497191394156797913
setupStore7414278
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -61.13 KiB (-1.03%)
  • ui: 2.63 KiB (0.04%)
  • common: 68.73 KiB (0.73%)

Copy link
Member

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM awesome work!!

@chloeYue chloeYue added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 8611ef9 Mar 31, 2025
147 checks passed
@chloeYue chloeYue deleted the migrate-tests-nft branch March 31, 2025 14:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants