Skip to content

Conversation

@seaona
Copy link
Member

@seaona seaona commented Mar 28, 2025

Description

We click on the token button right after landing to home page, which should open a dropdown, where we click Import tokens. If we did this and there's a re-render in between, the dropdown is closed and we cannot proceed with click Import

Screenshot from 2025-03-28 16-03-31

ci failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/134267/workflows/ac93c56c-3c54-40a2-86d0-93400205789a/jobs/4698667/tests

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Check ci

Screenshots/Recordings

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Mar 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [a808ad1]
UI Startup Metrics (1250 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1250114714106012841370
load10859771257611135987
domContentLoaded10799741251611143984
domInteractive18145961729
firstPaint7901381256421197990
backgroundConnect117939910
firstReactRender21155672140
getState11531779
initialActions001001
loadScripts857724101761892961
setupStore8518389
WebpackHomeuiStartup921779112667935958
load78658391860818872
domContentLoaded78056590660813860
domInteractive15115781335
firstPaint46253887333807834
backgroundConnect15104881437
firstReactRender13122931321
getState6313177
initialActions001001
loadScripts77855589660811850
setupStore7411179
FirefoxBrowserifyHomeuiStartup13511192178412813881701
load12151073163412012521538
domContentLoaded12151073163412012521538
domInteractive9235156239098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24175472536
firstReactRender23195562232
getState6336378
initialActions001001
loadScripts11921055161211812351504
setupStore6423267
WebpackHomeuiStartup10038481609162904964
load8737341375137826980
domContentLoaded8727341374137826980
domInteractive109342022716194
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2114100112432
firstReactRender19173231925
getState104761279
initialActions001001
loadScripts8547191344133831981
setupStore105821179
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@seaona seaona marked this pull request as ready for review March 28, 2025 14:54
@seaona seaona changed the title fix: flay test Token List should not show percentage increase for an ERC20 token without prices available fix: flaky test Token List should not show percentage increase for an ERC20 token without prices available Mar 28, 2025
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jun 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

@github-actions github-actions bot closed this Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky tests stale issues and PRs marked as stale team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants