Skip to content

Conversation

@seaona
Copy link
Member

@seaona seaona commented Mar 29, 2025

Description

This PR adds the multicall3 contract into the swaps network state.
This will be needed for when we perform more complex swaps, as this contract is used to perform batch calls.

It's a stateless contract so we don't need to modify anything in its storage.

The existing swap with state spec should continue to work normally.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Ci should continue to work

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Mar 29, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [5c3b91e]
UI Startup Metrics (1172 ± 52 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1172104413195212121253
load1021929117447959994
domContentLoaded1014922117148949990
domInteractive16134751626
firstPaint7771431128374275994
backgroundConnect106496910
firstReactRender18133841927
getState10429769
initialActions001001
loadScripts80068891146833877
setupStore7417278
WebpackHomeuiStartup932820116868945964
load78959693568825890
domContentLoaded78357692369820885
domInteractive15128091336
firstPaint51556893321816835
backgroundConnect16115491445
firstReactRender14122931323
getState6415278
initialActions001000
loadScripts78156691369818877
setupStore7413289
FirefoxBrowserifyHomeuiStartup13841185185713814121763
load12461068170913112781604
domContentLoaded12461068170913112771603
domInteractive9837227318696
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2616138182538
firstReactRender22193332328
getState7428378
initialActions004101
loadScripts12211051168613012541579
setupStore74757675
WebpackHomeuiStartup9948411599164891954
load8727261392146817982
domContentLoaded8717261392146826984
domInteractive114362002614596
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2114102122233
firstReactRender19163631925
getState9465989
initialActions001001
loadScripts8547111369143837971
setupStore8545678
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -63.09 KiB (-1.07%)
  • ui: 2.58 KiB (0.04%)
  • common: 68.28 KiB (0.73%)

@seaona seaona self-assigned this Mar 31, 2025
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jun 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

@github-actions github-actions bot closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale issues and PRs marked as stale team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants