Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Apr 24, 2025

Description

Cherry-pick of #32237 for 12.17.0.

Creating manual PR as controller patch required for @metamask/transaction-controller.

Patch changes are a cherry-pick of #5704 and built from patch/transaction-controller-extension-12-17-0.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Apr 24, 2025
@DDDDDanica
Copy link
Contributor

Hey @matthewwalsh0 would you mind adding changelog so we can pick it up, thank you !

@seaona
Copy link
Member

seaona commented Apr 24, 2025

I see the issue fixed on my end 🙌

getcapabilities-networks.mp4

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review April 24, 2025 12:35
@DDDDDanica DDDDDanica enabled auto-merge (squash) April 24, 2025 13:07
@DDDDDanica DDDDDanica merged commit d4f9a09 into Version-v12.17.0 Apr 24, 2025
155 of 156 checks passed
@DDDDDanica DDDDDanica deleted the fix/cherry-pick-12-17-0-batch-check-errors branch April 24, 2025 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [f95a92f]
UI Startup Metrics (1274 ± 80 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1274113616408013051430
load11029391434811157978
domContentLoaded10969331426801153970
domInteractive19146791736
firstPaint757861431440264956
backgroundConnect8456689
firstReactRender24165382746
getState14553989
initialActions001001
loadScripts842694116078874943
setupStore9533579
WebpackHomeuiStartup21871818253219523162451
load16971396207216818162017
domContentLoaded16891393206116718062007
domInteractive16135081543
firstPaint165713725621780
backgroundConnect291477143865
firstReactRender195584171146297
getState14452869
initialActions318144
loadScripts16841391203316418021979
setupStore35730859258
FirefoxBrowserifyHomeuiStartup14001196200913714661684
load12521073185313413171511
domContentLoaded12511072185313413171511
domInteractive10136385448598
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect221396122144
firstReactRender23203022428
getState8440589
initialActions001001
loadScripts12321058183513312971488
setupStore6415267
WebpackHomeuiStartup15621401202613116201858
load13481209176411614101607
domContentLoaded13471209176411614101606
domInteractive9564176199097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23167692441
firstReactRender36305753848
getState10457799
initialActions101011
loadScripts13281187174511613871586
setupStore9549689

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants