feat(support): adopt support consent flow in SRPErrorScreen and SocialLoginErrorSheet

[NicolasMassart]

Description

This PR adopts the support-consent mechanism introduced in #33424 (base branch MCWP-684-support-consent-core) in the "Contact support" flows of SRPErrorScreen and SocialLoginErrorSheet. Instead of opening the MetaMask support URL directly, both flows now route through the support consent sheet first, and only open the support URL after the user confirms (or rejects and falls back to the plain URL).

This PR is part of a stacked series on top of #33424. Its base will be retargeted to main once the core PR merges.

Changelog

CHANGELOG entry: null

(Behavior already described in the core PR, #33424.)

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-684

Manual testing steps

Feature: Support consent on wallet creation error flows

  Scenario: user taps Contact support on the SRP error screen
    Given the user is on the SRP error screen

    When the user taps "MetaMask Support"
    Then the support consent sheet is displayed first
    And confirming opens the MetaMask support URL

  Scenario: user taps Contact support on the social login error sheet
    Given the user is on the social login error sheet

    When the user taps "MetaMask Support"
    Then the support consent sheet is displayed first
    And confirming opens the MetaMask support URL

Screenshots/Recordings

N/A — logic-only change, no UI beyond the already-reviewed SupportConsentSheet from the core PR.

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Onboarding error UX only; behavior change is gating support behind an existing consent flow with no auth or data-handling changes.

Overview
Contact support on the SRP and social-login wallet creation error UIs no longer opens the support URL immediately. Both screens now call openSupportWithConsent from useSupportConsent, passing a callback that uses Linking.openURL and the existing AppConstants.REVIEW_PROMPT.SUPPORT base URL so the shared consent sheet runs first (per the core support-consent work).

Tests were updated to mock useSupportConsent, assert openSupportWithConsent is invoked with the opener and support URL, and add a small test that invoking the passed opener still calls Linking.openURL. Copy/retry-related tests were tightened with act and toBeOnTheScreen instead of waitFor where appropriate.

^{Reviewed by Cursor Bugbot for commit a959038. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (MCWP-684-support-consent-core@79174d2). Learn more about missing BASE report.

Additional details and impacted files

@@                       Coverage Diff                        @@
##             MCWP-684-support-consent-core   #33523   +/-   ##
================================================================
  Coverage                                 ?   84.72%           
================================================================
  Files                                    ?     6206           
  Lines                                    ?   166577           
  Branches                                 ?    40717           
================================================================
  Hits                                     ?   141136           
  Misses                                   ?    15815           
  Partials                                 ?     9626           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🧪 Flaky unit test detection

✅ All previously detected unit test flakiness issues in this PR have been fixed.

View recent run history

This check is informational only and does not block merging.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeSeedlessOnboarding, SmokeAccounts
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 82%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR modifies two wallet creation error screens:

1. SRPErrorScreen.tsx: Error screen shown when SRP-based wallet creation fails. Changed to use useSupportConsent hook instead of directly calling Linking.openURL() for the support link. This affects the SRP onboarding error path.

2. SocialLoginErrorSheet.tsx: Error sheet shown when social login (seedless onboarding) fails. Same change - replaces direct Linking.openURL() with openSupportWithConsent() from useSupportConsent hook.

3. Test files: Unit test updates to mock useSupportConsent and verify the new behavior pattern.

Why these tags:

• SmokeSeedlessOnboarding: SocialLoginErrorSheet is directly part of the seedless/social login onboarding error flow. The change modifies how the support link works in this error state.
• SmokeAccounts: SRPErrorScreen is part of the SRP-based wallet creation error flow, which is covered under account creation/onboarding tests.

Risk assessment:

• Low risk: Changes are confined to error screens (not happy paths)
• The useSupportConsent hook is already used in multiple other components (MoreSection, EligibilityFailedModal, MoneyMoreSheet, ReviewModal), so it's a proven pattern
• No core infrastructure, controllers, or navigation changes
• No performance impact expected - this is a UI-only change in error states

No performance tests needed: These are error screen UI changes with no impact on app launch, login, onboarding performance metrics, or any measured performance flows.

Performance Test Selection:
The changes are confined to error screens in the wallet creation flow (SRPErrorScreen and SocialLoginErrorSheet). They only modify how the support URL is opened (adding a consent step via useSupportConsent hook). There is no impact on app launch time, login performance, onboarding flow performance metrics, or any other measured performance scenarios.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud