chore: remove price alerts FF - #33599
Conversation
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
No E2E smoke tests exist for NotificationsSettings or TokenDetails price alerts functionality. The changes don't affect core navigation, confirmations, accounts, swaps, browser, snaps, or any other major user flows covered by the available smoke tags. The risk is low as this is a feature flag removal (graduating the feature to always-on), and the affected components are isolated to notification settings and token detail views. Performance Test Selection: |
|



Description
Remove price alerts FF
Changelog
CHANGELOG entry: remove price alerts FF
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3704
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Price alerts UI and settings become always available (subject to existing chain/price checks), and supported-chains fetches are no longer skippable via the removed flag—there is no remote kill switch for the feature.
Overview
Removes the remote
priceAlertsEnabledfeature flag and makes price alerts behavior unconditional wherever it was previously gated.Token details no longer reads
selectPriceAlertsEnabled. The header price-alert action is shown when chain support, a resolvable CAIP-19 id, and a positive USD price are satisfied.useIsPriceAlertsChainSupportedalways runs its supported-chains query (the optionalenabledargument is removed).Notification settings always lists the Price Alerts section when MetaMask notifications are on, instead of hiding it behind the flag.
The selector module, registry entry, and related test/preset wiring for
priceAlertsEnabledare deleted; tests are updated to match the new gating (including a stabler retry test for the chain-support hook).Reviewed by Cursor Bugbot for commit 78acadd. Bugbot is set up for automated code reviews on this repo. Configure here.