Skip to content

chore: remove price alerts FF - #33599

Merged
juanmigdr merged 4 commits into
mainfrom
chore/remove-price-alerts-ff
Jul 24, 2026
Merged

chore: remove price alerts FF#33599
juanmigdr merged 4 commits into
mainfrom
chore/remove-price-alerts-ff

Conversation

@juanmigdr

@juanmigdr juanmigdr commented Jul 21, 2026

Copy link
Copy Markdown
Member

Description

Remove price alerts FF

Changelog

CHANGELOG entry: remove price alerts FF

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3704

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Price alerts UI and settings become always available (subject to existing chain/price checks), and supported-chains fetches are no longer skippable via the removed flag—there is no remote kill switch for the feature.

Overview
Removes the remote priceAlertsEnabled feature flag and makes price alerts behavior unconditional wherever it was previously gated.

Token details no longer reads selectPriceAlertsEnabled. The header price-alert action is shown when chain support, a resolvable CAIP-19 id, and a positive USD price are satisfied. useIsPriceAlertsChainSupported always runs its supported-chains query (the optional enabled argument is removed).

Notification settings always lists the Price Alerts section when MetaMask notifications are on, instead of hiding it behind the flag.

The selector module, registry entry, and related test/preset wiring for priceAlertsEnabled are deleted; tests are updated to match the new gating (including a stabler retry test for the chain-support hook).

Reviewed by Cursor Bugbot for commit 78acadd. Bugbot is set up for automated code reviews on this repo. Configure here.

@juanmigdr
juanmigdr requested review from a team as code owners July 21, 2026 13:56
@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jul 21, 2026
@metamask-ci

metamask-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Manual testing steps still contain template content (the Gherkin example title or a [...] placeholder). Replace with real steps, or write N/A — <reason>.
  • Screenshots/Recordings section is empty. Add an image/video for user-facing changes, logs/console output for non-user-facing changes, or write N/A if no evidence is applicable.
  • Pre-merge author checklist has unchecked items (e.g. "I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@juanmigdr juanmigdr removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jul 21, 2026
@juanmigdr
juanmigdr enabled auto-merge July 21, 2026 13:57
@github-actions github-actions Bot added size-M risk:medium AI analysis: medium risk labels Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR removes the priceAlertsEnabled feature flag gate, making Price Alerts always available in the Notifications Settings and Token Details views. The changes are:

  1. Deleted selectPriceAlertsEnabled selector - removes the feature flag selector entirely
  2. NotificationsSettings/index.tsx - removes conditional rendering of the Price Alerts row (now always shown)
  3. TokenDetails.tsx - removes feature flag check; price alert button now shown whenever chain is supported and price > 0
  4. useIsPriceAlertsChainSupported.ts - removes the options.enabled parameter (query now always runs)
  5. feature-flag-registry.ts - removes priceAlertsEnabled registry entry
  6. Test/preset files - updated to reflect removed feature flag

No E2E smoke tests exist for NotificationsSettings or TokenDetails price alerts functionality. The changes don't affect core navigation, confirmations, accounts, swaps, browser, snaps, or any other major user flows covered by the available smoke tags. The risk is low as this is a feature flag removal (graduating the feature to always-on), and the affected components are isolated to notification settings and token detail views.

Performance Test Selection:
The changes remove a feature flag gate and simplify a React Query hook by removing the enabled option. The query for supported chains will now always run (previously could be disabled), but this is a minor change that doesn't introduce new performance-sensitive rendering paths or data fetching loops. No performance test scenarios cover Notifications Settings or Token Details price alert flows.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@MetaMask MetaMask deleted a comment from github-actions Bot Jul 24, 2026
@juanmigdr
juanmigdr added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit 5c8642a Jul 24, 2026
143 of 144 checks passed
@juanmigdr
juanmigdr deleted the chore/remove-price-alerts-ff branch July 24, 2026 10:36
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2026
@metamask-ci metamask-ci Bot added the release-8.6.0 Issue or pull request that will be included in release 8.6.0 label Jul 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.6.0 Issue or pull request that will be included in release 8.6.0 risk:medium AI analysis: medium risk size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants