Skip to content

feat: add TransactionPayController sentinel messenger test - #33754

Merged
dan437 merged 2 commits into
mainfrom
feat-transaction-pay-sentinel-messenger-test
Jul 24, 2026
Merged

feat: add TransactionPayController sentinel messenger test#33754
dan437 merged 2 commits into
mainfrom
feat-transaction-pay-sentinel-messenger-test

Conversation

@dan437

@dan437 dan437 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Follow-up to #33719: add a messenger unit test that asserts getTransactionPayControllerMessenger delegates SentinelApiService:simulateTransactions.

That delegation is the primary breaking integration required by @metamask/transaction-pay-controller v26. An explicit test keeps it from being dropped during future messenger refactors.

Changelog

CHANGELOG entry: null

Related issues

Refs: #33719

Manual testing steps

N/A — unit test only.

Screenshots/Recordings

N/A — no UI changes.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Cover SentinelApiService:simulateTransactions delegation so the v26 pay integration cannot be dropped in future messenger refactors.
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-confirmations Push issues to confirmations team label Jul 24, 2026
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🧪 Flaky unit test detection

✅ All previously detected unit test flakiness issues in this PR have been fixed.

View recent run history

This check is informational only and does not block merging.

@dan437
dan437 marked this pull request as ready for review July 24, 2026 08:57
@dan437
dan437 requested a review from a team as a code owner July 24, 2026 08:58
@cursor

cursor Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Current version of PR was reviewed by /review-bugbot with additional instructions on Jul 24, 10:53 GMT+2. It flagged 0 findings.

Bugbot on commit dd48fea is skipped.

Avoid spy leakage between cases flagged by flaky-test detection.
@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jul 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

@dan437
dan437 enabled auto-merge July 24, 2026 10:01
@dan437
dan437 added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit 4b9592a Jul 24, 2026
134 checks passed
@dan437
dan437 deleted the feat-transaction-pay-sentinel-messenger-test branch July 24, 2026 10:02
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2026
@metamask-ci metamask-ci Bot added the release-8.6.0 Issue or pull request that will be included in release 8.6.0 label Jul 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.6.0 Issue or pull request that will be included in release 8.6.0 risk:low AI analysis: low risk size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants