feat: add TransactionPayController sentinel messenger test - #33754
Merged
Conversation
Cover SentinelApiService:simulateTransactions delegation so the v26 pay integration cannot be dropped in future messenger refactors.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🧪 Flaky unit test detection✅ All previously detected unit test flakiness issues in this PR have been fixed. This check is informational only and does not block merging. |
dan437
marked this pull request as ready for review
July 24, 2026 08:57
Contributor
|
Current version of PR was reviewed by /review-bugbot with additional instructions on Jul 24, 10:53 GMT+2. It flagged 0 findings. Bugbot on commit |
Avoid spy leakage between cases flagged by flaky-test detection.
|
dan437
enabled auto-merge
July 24, 2026 10:01
matthewwalsh0
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Follow-up to #33719: add a messenger unit test that asserts
getTransactionPayControllerMessengerdelegatesSentinelApiService:simulateTransactions.That delegation is the primary breaking integration required by
@metamask/transaction-pay-controllerv26. An explicit test keeps it from being dropped during future messenger refactors.Changelog
CHANGELOG entry: null
Related issues
Refs: #33719
Manual testing steps
N/A — unit test only.
Screenshots/Recordings
N/A — no UI changes.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist