Skip to content

chore: delete multichain accounts feature flag - #33802

Merged
gantunesr merged 1 commit into
mainfrom
gar/chore/delete-multichain-ff
Jul 27, 2026
Merged

chore: delete multichain accounts feature flag#33802
gantunesr merged 1 commit into
mainfrom
gar/chore/delete-multichain-ff

Conversation

@gantunesr

Copy link
Copy Markdown
Member

Description

Multichain accounts is permanently enabled, so the remote feature flag helpers in app/multichain-accounts/remote-feature-flag.ts had been reduced to stubs that always return true. Nothing in the codebase imports isMultichainAccountsRemoteFeatureEnabled or isMultichainAccountsState2Enabled anymore, so this PR deletes the module and its test file to remove dead code.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

N/A — pure dead-code deletion with no runtime behavior change. Verified via search that no remaining code references the deleted functions, and CI (unit tests, TypeScript, lint) covers the rest.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

@metamask-ci metamask-ci Bot added the team-accounts-framework Accounts team label Jul 24, 2026
@metamask-ci

metamask-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Pre-merge author checklist has unchecked items (e.g. "I've tested on Android"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
Both changed files are being deleted:

  1. app/multichain-accounts/remote-feature-flag.ts - A stub file where both exported functions always returned true (permanently enabled, no real logic).
  2. app/multichain-accounts/remote-feature-flag.test.ts - The unit test for the above stub.

A codebase search confirmed that no other files import from app/multichain-accounts/remote-feature-flag — there are zero downstream consumers. This is pure dead-code cleanup with no functional impact on any user flows, UI components, controllers, or E2E test paths. No E2E tags or performance tests are warranted.

Performance Test Selection:
The deleted files were stubs that always returned true with no performance-sensitive logic. No performance-impacting code paths are affected.

View GitHub Actions results

@gantunesr
gantunesr marked this pull request as ready for review July 24, 2026 20:12
@gantunesr
gantunesr requested a review from a team as a code owner July 24, 2026 20:12
@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jul 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

@gantunesr
gantunesr added this pull request to the merge queue Jul 27, 2026
Merged via the queue into main with commit bed38cd Jul 27, 2026
199 of 207 checks passed
@gantunesr
gantunesr deleted the gar/chore/delete-multichain-ff branch July 27, 2026 13:20
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 27, 2026
@metamask-ci metamask-ci Bot added the release-8.6.0 Issue or pull request that will be included in release 8.6.0 label Jul 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.6.0 Issue or pull request that will be included in release 8.6.0 risk:low AI analysis: low risk size-S team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants