test: MMQA-2092 migrate wallet browser smoke to Appium 1/2 by vivek-consensys · Pull Request #33816 · MetaMask/metamask-mobile

vivek-consensys · 2026-07-27T08:21:46Z

Description

Part 1/2 of MMQA-2092: migrates Detox wallet browser download and navigation smoke coverage to Appium so these flows run in the Appium smoke pipeline.

Adds tests/smoke-appium/wallet/browser/browser-download.spec.ts and browser-navigation.spec.ts
Removes the corresponding Detox specs under tests/smoke/wallet/browser/
Hardens shared Browser page objects / external website POs for Appium (selectors, waits, download handling)
Adds browser-url-display-text testID so URL-bar focus works without coordinate taps
Extends Playwright assertions for Appium URL / text checks where needed
Skips the cross-origin redirect URL-bar assertion until #33815 / MCWP-540 (URL bar does not update after JS cross-origin redirects)

Changelog

CHANGELOG entry: null

Related issues

Fixes: MMQA-2092

Manual testing steps

Feature: Wallet browser Appium smoke (download + navigation)

  Scenario: downloads a file from the browser
    Given the Appium main-e2e build is installed on a simulator or emulator
    And fixtures start with an imported wallet and browser available
    When the user opens the download test dapp and triggers a download
    Then the download completes successfully

  Scenario: navigates browser history and URL bar flows
    Given the Appium main-e2e build is installed on a simulator or emulator
    And fixtures start with an imported wallet and browser available
    When the user navigates between pages via URL bar / back / forward
    Then the browser URL and page content update as expected

  Scenario: cross-origin redirect URL bar (skipped)
    Given a JS cross-origin redirect occurs in the in-app browser
    Then the URL bar should show the redirected origin
    # Currently skipped — tracked by MetaMask/metamask-mobile#33815

Local commands:

# iOS
IOS_APP_PATH=build/ci-main-e2e/MetaMask.app \
yarn appium-smoke:ios \
  tests/smoke-appium/wallet/browser/browser-download.spec.ts \
  tests/smoke-appium/wallet/browser/browser-navigation.spec.ts

# Android
ANDROID_APK_PATH=build/ci-main-e2e/app-prod-release.apk \
yarn appium-smoke:android \
  tests/smoke-appium/wallet/browser/browser-download.spec.ts \
  tests/smoke-appium/wallet/browser/browser-navigation.spec.ts

Screenshots/Recordings

N/A — E2E/test-focused change (small testID addition only); no end-user product UI change.

Before

N/A

After

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
I've tested with a power user scenario
- Use these power-user SRPs to import wallets with many accounts and tokens
I've instrumented key operations with Sentry traces for production performance metrics
- See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

…MQA-2092) Move Detox browser download/navigation specs to smoke-appium with Appium page objects and selectors, and add a URL display Text testID so URL-bar focus works without coordinate taps. Co-authored-by: Cursor <cursoragent@cursor.com>

Rely on page-load waits instead of a hardcoded post-submit delay. Co-authored-by: Cursor <cursoragent@cursor.com>

Skip until #33815 — URL bar does not update after JS cross-origin redirects (MCWP-540). Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-07-27T08:21:54Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamask-ci · 2026-07-27T08:22:31Z

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

Pre-merge author checklist has unchecked items (e.g. "I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

Replace hardcoded waitForExist/waitAndTap timeouts with existing assertion and gesture helpers, and route expectElementNotToHaveText through executeWithRetry. Co-authored-by: Cursor <cursoragent@cursor.com>

Move download dialog selectors into a shared selectors file and rely on framework default timeouts for BrowserView, DownloadFile, and ENS retry. Co-authored-by: Cursor <cursoragent@cursor.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 9579dc8. Configure here.}

Use browser-url-display-text instead of the url-input wrapper so expectUrlNotEqualTo cannot pass on empty getText(). Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-07-27T12:17:37Z

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

sonarqubecloud · 2026-07-27T12:39:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vivek-consensys and others added 3 commits July 24, 2026 15:33

test(e2e): drop fixed settle sleep after Appium URL-bar navigation

38f3767

Rely on page-load waits instead of a hardcoded post-submit delay. Co-authored-by: Cursor <cursoragent@cursor.com>

test(e2e): skip Appium cross-origin redirect URL bar assertion

5eaf511

Skip until #33815 — URL bar does not update after JS cross-origin redirects (MCWP-540). Co-authored-by: Cursor <cursoragent@cursor.com>

metamask-ci Bot added the team-qa QA team label Jul 27, 2026

github-actions Bot added the size-L label Jul 27, 2026

vivek-consensys and others added 3 commits July 27, 2026 13:06

test(e2e): reuse shared waits in Appium browser page objects

6807e4b

Replace hardcoded waitForExist/waitAndTap timeouts with existing assertion and gesture helpers, and route expectElementNotToHaveText through executeWithRetry. Co-authored-by: Cursor <cursoragent@cursor.com>

test(e2e): centralize download selectors and drop hardcoded waits

1d6c57a

Move download dialog selectors into a shared selectors file and rely on framework default timeouts for BrowserView, DownloadFile, and ENS retry. Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'main' into MMQA-2092-wallet-browser-smoke-appium

4cf50bc

vivek-consensys added the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label Jul 27, 2026

Merge branch 'main' into MMQA-2092-wallet-browser-smoke-appium

9579dc8

vivek-consensys marked this pull request as ready for review July 27, 2026 11:49

vivek-consensys requested a review from a team as a code owner July 27, 2026 11:49

github-actions Bot added the risk:medium AI analysis: medium risk label Jul 27, 2026

cursor Bot reviewed Jul 27, 2026

View reviewed changes

Comment thread tests/page-objects/Browser/BrowserView.ts

fix(e2e): read Appium URL assertions from display text

602a5b8

Use browser-url-display-text instead of the url-input wrapper so expectUrlNotEqualTo cannot pass on empty getText(). Co-authored-by: Cursor <cursoragent@cursor.com>

cmd-ob approved these changes Jul 27, 2026

View reviewed changes

vivek-consensys added this pull request to the merge queue Jul 27, 2026

Merged via the queue into main with commit 54e4635 Jul 27, 2026
287 of 289 checks passed

vivek-consensys deleted the MMQA-2092-wallet-browser-smoke-appium branch July 27, 2026 14:39

github-actions Bot locked and limited conversation to collaborators Jul 27, 2026

metamask-ci Bot added the release-8.6.0 Issue or pull request that will be included in release 8.6.0 label Jul 27, 2026

Navigation Menu

Uh oh!

Uh oh!

test: MMQA-2092 migrate wallet browser smoke to Appium 1/2 - #33816

test: MMQA-2092 migrate wallet browser smoke to Appium 1/2#33816
vivek-consensys merged 8 commits into
mainfrom
MMQA-2092-wallet-browser-smoke-appium

vivek-consensys commented Jul 27, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

metamask-ci Bot commented Jul 27, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

sonarqubecloud Bot commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

vivek-consensys commented Jul 27, 2026

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

metamask-ci Bot commented Jul 27, 2026

PR template — items to address before "Ready for review"

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 27, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented Jul 27, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants