feat: add favorite when an alert is created

[juanmigdr]

Description

Automatically adds a token to the user’s watchlist after they successfully create their first price alert for that token. This reuses the existing watchlist add mutation, only applies to new alert creation when the token had no existing alerts, and leaves edits, failed saves, and tokens with existing alerts unchanged; focused tests cover both the save-flow behavior and the screen-level flag calculation.

Segment schema changes: https://github.com/Consensys/segment-schema/pull/691

Changelog

CHANGELOG entry: add favorite when an alert is created

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3699

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Scoped UX change reusing an existing mutation, gated on successful create with no existing alerts; behavior is covered by unit tests.

Overview
After a successful first price alert for a token, the app now adds that asset to the watchlist via the existing watchlist add mutation and fires WATCHLIST_TOKEN_ADDED with source price_alert_creation.

CreatePriceAlertView passes shouldAutoWatchlistOnCreate into useAlertSaveFlow only when the user is creating (not editing) and there are no existing absolute or percent alerts for that asset. Edits, failed saves, and additional alerts for tokens that already have alerts do not touch the watchlist.

Tests cover the save-flow hook and the screen-level flag wiring. WatchlistAnalytics.ADD_SOURCE.PRICE_ALERT_CREATION was added for analytics.

^{Reviewed by Cursor Bugbot for commit b9f40e1. Bugbot is set up for automated code reviews on this repo. Configure here.}

[metamask-ci]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Manual testing steps still contain template content (the Gherkin example title or a [...] placeholder). Replace with real steps, or write N/A — <reason>.
• Screenshots/Recordings section is empty. Add an image/video for user-facing changes, logs/console output for non-user-facing changes, or write N/A if no evidence is applicable.
• Pre-merge author checklist has unchecked items (e.g. "I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 88%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR modifies Price Alerts and Watchlist components:

1. CreatePriceAlertView.tsx: Adds shouldAutoWatchlistOnCreate logic to auto-add a token to the watchlist when creating the first price alert.
2. useAlertSaveFlow.ts: Integrates useTokenWatchlistAddItemMutation to auto-add assets to watchlist on first price alert creation, with analytics tracking.
3. watchlistAnalytics.ts: Adds a new ADD_SOURCE.PRICE_ALERT_CREATION analytics constant.
4. ManagePriceAlertsView.tsx: Pure cosmetic variable rename (alert → priceAlert) with zero functional impact.
5. Test files: Unit test updates for the above changes.

These changes are entirely within the Price Alerts and Watchlist feature area. None of the available E2E smoke tags cover Price Alerts or Watchlist functionality directly. The changes do not affect:

• Core navigation/TabBar components
• Confirmation flows
• Account management
• Network management
• Swap/bridge flows
• Snaps
• Browser
• Onboarding

The changes are well-contained feature additions with unit test coverage. No shared components that could break other E2E test suites are modified.

Performance Test Selection:
The changes are limited to Price Alerts creation flow and Watchlist auto-add functionality. No performance-sensitive paths are affected — no asset loading loops, no rendering performance changes, no login/onboarding/launch flows, no swap flows. The changes add a single mutation call on price alert creation, which is not a performance-critical path covered by any available performance test tag.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud