Skip to content

ci(appium): unify seedless smoke tag and raise seedless/wallet shards - #34028

Merged
cmd-ob merged 1 commit into
mainfrom
cursor/appium-seedless-wallet-shards-f153
Jul 30, 2026
Merged

ci(appium): unify seedless smoke tag and raise seedless/wallet shards#34028
cmd-ob merged 1 commit into
mainfrom
cursor/appium-seedless-wallet-shards-f153

Conversation

@cmd-ob

@cmd-ob cmd-ob commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

Merges Appium seedless onboarding into a single smoke group and raises shards for two suites that were pressing the job timeout:

  1. Seedless — former SmokeSeedlessOnboardingExtended specs now use SmokeSeedlessOnboarding. The separate extended CI jobs are removed. One Appium suite runs with 4 shards on Android and iOS.
  2. Wallet platform — Appium shards raised from 2 → 4 on Android and iOS (iOS shard 1 was ~23m on the test-run step).

Core and extended seedless specs do not duplicate assertions; extended flows only reuse new-user onboarding as setup before asserting add-SRP, lock/unlock, reset, QR sync, or attribution.

Changelog

CHANGELOG entry: null

Related issues

Refs: #33898

Manual testing steps

N/A — CI workflow and smoke-tag wiring only; no app runtime behavior change. Validation is via Appium smoke CI for SmokeSeedlessOnboarding and SmokeWalletPlatform.

Screenshots/Recordings

N/A — no user-facing UI changes.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Fold former SmokeSeedlessOnboardingExtended specs into
SmokeSeedlessOnboarding, run them as one Appium suite with 4 shards, and
raise wallet-platform Appium shards from 2 to 4.

Co-authored-by: cmd-ob <cmd-ob@users.noreply.github.com>
@metamask-ci metamask-ci Bot added team-qa QA team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jul 30, 2026
@metamask-ci

metamask-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Pre-merge author checklist has unchecked items (e.g. "I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSeedlessOnboarding
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR consolidates the SmokeSeedlessOnboardingExtended tag into SmokeSeedlessOnboarding:

  1. tags.js: Removes SmokeSeedlessOnboardingExtended entirely and merges its description/scope into SmokeSeedlessOnboarding. The unified tag now covers both core seedless onboarding AND extended flows (QR sync, add-SRP, attribution analytics, lock/unlock, reset wallet).

  2. 5 spec files in tests/smoke-appium/seedless/: All previously tagged with SmokeSeedlessOnboardingExtended are now re-tagged with SmokeSeedlessOnboarding:

    • google-login-add-srp.spec.ts
    • google-login-lock-unlock.spec.ts
    • google-login-reset-wallet.spec.ts
    • qr-sync-srp.spec.ts
    • wallet-setup-completed-attribution.spec.ts
  3. CI workflows (android + ios): Removed the separate appium-seedless-onboarding-extended-* jobs, updated the main seedless job to use SmokeSeedlessOnboarding (without trailing colon workaround) with 4 splits instead of 1. Also increased SmokeWalletPlatform splits from 2 to 4.

The key risk is that the tag migration must work correctly — the 5 re-tagged specs must now be picked up by the SmokeSeedlessOnboarding runner. Running SmokeSeedlessOnboarding validates the entire consolidated suite. No app code was changed, so no other test areas are affected. SmokeWalletPlatform split increase is a CI parallelism change only (no tag change), so it doesn't require additional tag selection here.

Performance Test Selection:
No app code was changed — only test spec tag migrations, CI workflow parallelism adjustments, and tag definition consolidation in tags.js. None of these changes affect app performance characteristics, rendering times, or measured user flows. No performance tests are needed.

View GitHub Actions results

@cmd-ob
cmd-ob marked this pull request as ready for review July 30, 2026 02:46
@cmd-ob
cmd-ob requested a review from a team as a code owner July 30, 2026 02:46
@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jul 30, 2026
@metamask-ci metamask-ci Bot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 30, 2026
@sonarqubecloud

Copy link
Copy Markdown

@cmd-ob
cmd-ob enabled auto-merge July 30, 2026 06:48
@cmd-ob
cmd-ob added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit a643200 Jul 30, 2026
140 checks passed
@cmd-ob
cmd-ob deleted the cursor/appium-seedless-wallet-shards-f153 branch July 30, 2026 07:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 30, 2026
@metamask-ci metamask-ci Bot added the release-8.6.0 Issue or pull request that will be included in release 8.6.0 label Jul 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.6.0 Issue or pull request that will be included in release 8.6.0 risk:low AI analysis: low risk size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants