test(e2e): strengthen Appium Snap helpers ahead of remaining migrations by cmd-ob · Pull Request #34054 · MetaMask/metamask-mobile

cmd-ob · 2026-07-30T12:07:00Z

Summary

Shared WebView/Appium helper improvements (WebView, Utilities, gestures, emulator helpers) used by Snap smokes.
TestSnaps page-object/selector updates, snap navigation flows, and related page-object tweaks.
Scale Appium SmokeSnaps shards (and Android timeout) ahead of migrating the remaining Detox snap suites.

Split from #33898. Specs migration and Detox CI removal follow in stacked PRs.

Test plan

Confirm Appium SmokeSnaps CI still passes on existing Appium snap suites with 8 shards
Spot-check that Detox SmokeSnaps jobs remain unchanged (still covering remaining Detox suites)
No snap spec add/delete in this PR

Made with Cursor

Shared WebView/Appium utilities, TestSnaps page objects/selectors, snap flows, and SmokeSnaps shard scaling so remaining Detox→Appium snap migrations can land as specs-only. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-07-30T12:07:10Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamask-ci · 2026-07-30T12:07:56Z

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

PR body does not match pull-request-template.md (one or more section headings are missing). See https://github.com/MetaMask/metamask-mobile/blob/main/.github/scripts/shared/pr-template-checks.ts#L15-L23.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 139b1f6. Configure here.}

… helper Re-merge PlaywrightGestures onto latest main so the named export used by unit tests is not dropped when adding typeViaIosKeyboard. Co-authored-by: Cursor <cursoragent@cursor.com>

Gate Appium WebView.blurActiveElement behind FrameworkDetector so Detox SmokeSnaps signing flows still blur via the main Detox WebView script. Co-authored-by: Cursor <cursoragent@cursor.com>

vivek-consensys · 2026-07-30T12:53:40Z

+   * Dialog Snap custom input. iOS uses textfield selector as testID
+   * is not exposed in page source.
+   */
+  async fillCustomDialogInput(text: string) {


Should we move this into TestSnaps.selectors.ts?

Moved the locator strings (testIDs / iOS XPath) into TestSnaps.selectors.ts; left resolve/encapsulated in the page object.

vivek-consensys · 2026-07-30T12:56:12Z

+            `.resourceIdMatches(".*snap-ui-renderer__selector-item.*").childSelector(new UiSelector().text("${text}"))`,
+          ),
+        ios: () =>
+          PlaywrightMatchers.getElementByXPath(


Same as above, can it be moved into TestSnaps.selectors.ts?

Same here — selector-item ID + Android/iOS locator string builders now live in TestSnaps.selectors.ts; encapsulated stays in the page object.

Keep resolve/encapsulated wiring in the page object; hoist custom-input and selector-item IDs/XPaths into TestSnaps.selectors.ts. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-07-30T13:09:07Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps, SmokeMMConnect
Selected Performance tags: None (no tests recommended)
Risk Level: high
AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (test-framework-infra-change): Test framework infrastructure changed: tests/framework/Assertions.ts, tests/framework/Utilities.ts, tests/framework/fixtures/FixtureUtils.ts. Running all tests.

Performance Test Selection:
No app source code changes are present in this PR - all changes are to test infrastructure (page objects, flows, framework utilities, selectors, CI workflows, and the AI analyzer prompt). Performance tests measure app responsiveness and render times based on app code changes, not test framework changes. The FixtureUtils.ts change is a test utility fix, not an app performance change. Therefore no performance test tags are warranted.

View GitHub Actions results

vivek-consensys

LGTM

sonarqubecloud · 2026-07-30T13:27:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cmd-ob requested a review from a team as a code owner July 30, 2026 12:07

metamask-ci Bot added team-qa QA team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jul 30, 2026

cmd-ob mentioned this pull request Jul 30, 2026

test(e2e): migrate remaining Detox Snap smokes to Appium #34056

Closed

10 tasks

github-actions Bot added the size-L label Jul 30, 2026

cursor Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread tests/page-objects/Browser/TestSnaps.ts Outdated

cmd-ob mentioned this pull request Jul 30, 2026

test(e2e): migrate remaining Detox snap smokes to Appium #33898

Closed

10 tasks

github-actions Bot added the risk:medium AI analysis: medium risk label Jul 30, 2026

cmd-ob and others added 2 commits July 30, 2026 13:23

fix(tests): preserve assertResolvedElementId when adding iOS keyboard…

3605950

… helper Re-merge PlaywrightGestures onto latest main so the named export used by unit tests is not dropped when adding typeViaIosKeyboard. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(tests): keep Detox blur path for remaining Snap smokes

f06ab68

Gate Appium WebView.blurActiveElement behind FrameworkDetector so Detox SmokeSnaps signing flows still blur via the main Detox WebView script. Co-authored-by: Cursor <cursoragent@cursor.com>

vivek-consensys reviewed Jul 30, 2026

View reviewed changes

refactor(tests): move Snap UI locator strings into TestSnaps selectors

e84c21a

Keep resolve/encapsulated wiring in the page object; hoist custom-input and selector-item IDs/XPaths into TestSnaps.selectors.ts. Co-authored-by: Cursor <cursoragent@cursor.com>

cmd-ob requested a review from vivek-consensys July 30, 2026 13:07

vivek-consensys approved these changes Jul 30, 2026

View reviewed changes

cmd-ob enabled auto-merge July 30, 2026 14:09

cmd-ob added this pull request to the merge queue Jul 30, 2026

Merged via the queue into main with commit 957031c Jul 30, 2026
315 of 317 checks passed

cmd-ob deleted the e2e/snaps-appium-foundation branch July 30, 2026 14:51

github-actions Bot locked and limited conversation to collaborators Jul 30, 2026

metamask-ci Bot added the release-8.6.0 Issue or pull request that will be included in release 8.6.0 label Jul 30, 2026

Uh oh!

Uh oh!

Conversation

cmd-ob commented Jul 30, 2026

Summary

Test plan

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

metamask-ci Bot commented Jul 30, 2026

PR template — items to address before "Ready for review"

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vivek-consensys Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

cmd-ob Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

cmd-ob Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

vivek-consensys Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

cmd-ob Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

cmd-ob Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 30, 2026

🔍 Smart E2E Test Selection

Uh oh!

vivek-consensys left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 30, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants