chore(runway): cherry-pick feat: MUSD-1229 Update money-acount-balance-service cp-8.6.0 - #34096
Merged
Merged
Conversation
…e-service cp-8.6.0 (#34084) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> <!-- mms-check directive vocabulary — read by .github/scripts/shared/pr-template-checks.ts at module load to build the validation plan. Directives are invisible in rendered markdown and must NOT be removed or edited without updating the validator registry. type=text Section must contain non-placeholder prose. type=changelog Section must have a valid CHANGELOG entry: line. type=issue-link Section must have a Fixes:/Closes:/Refs: line with a value. type=manual-testing Section must have real testing steps or an explicit N/A. type=screenshot Section must have evidence (image/URL) or an explicit N/A. type=checklist Section must have all checkboxes consciously checked. required=true|false Whether a missing/invalid section runs the validator at all. blocking=true|false Whether a failure of this check fails the CI workflow. Default: false — failures are shown as warnings in the sticky comment but do not block the PR. Sections without a directive are checked for structural presence only. --> ## **Description** <!-- mms-check: type=text required=true --> Bump `@metamask/money-account-balance-service` to `^2.4.0`. Needed to convert Veda API's APR to APY. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- mms-check: type=changelog required=true blocking=true --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: update @metamask/money-account-balance-service to ^2.4.0 ## **Related issues** <!-- mms-check: type=issue-link required=true --> Fixes: [MUSD-1229: Update money-acount-balance-service in Mobile app + Ensure we're not compounding clientside already](https://consensyssoftware.atlassian.net/browse/MUSD-1229) ## **Manual testing steps** <!-- mms-check: type=manual-testing required=true --> N/A - package bump ## **Screenshots/Recordings** <!-- mms-check: type=screenshot required=true --> <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> N/A - package bump ### **After** <!-- [screenshots/recordings] --> N/A - package bump ## **Pre-merge author checklist** <!-- mms-check: type=checklist required=true --> <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes how Money account yield (APY) is derived for user-facing balances and copy, with no in-repo code review of the package diff—incorrect rates would be a product/trust issue rather than an auth or data breach. > > **Overview** > Updates **`@metamask/money-account-balance-service`** from **^2.3.0** to **^2.4.0** in `package.json` and refreshes **`yarn.lock`**. The resolved **2.4.0** package now pulls **`@metamask/money-account-api-data-service` ^0.4.0** as a transitive dependency (replacing the older **^0.2.0** tree entry in the lockfile). > > There are **no application source changes** in this PR—Money UI continues to consume balances/APY via existing hooks such as `useMoneyAccountBalance`. The bump is intended to pick up library behavior for **Veda API APR→APY** handling and to avoid **double-compounding yield on the client** (per MUSD-1229). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c0606cf. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamask-ci
Bot
added
the
team-bots
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
HowardBraham
enabled auto-merge (squash)
July 30, 2026 23:10
HowardBraham
approved these changes
Jul 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/8.6.0 #34096 +/- ##
================================================
Coverage ? 84.89%
================================================
Files ? 6272
Lines ? 169943
Branches ? 41644
================================================
Hits ? 144276
Misses ? 15834
Partials ? 9833 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
metamaskbot
added
the
release-8.6.0
Contributor
|
No release label on PR. Adding release label release-8.6.0 on PR, as PR was cherry-picked in branch 8.6.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump
@metamask/money-account-balance-serviceto^2.4.0. Needed toconvert Veda API's APR to APY.
Changelog
CHANGELOG entry: update @metamask/money-account-balance-service to
^2.4.0
Related issues
Fixes: MUSD-1229: Update money-acount-balance-service in Mobile app +
Ensure we're not compounding clientside
already
Manual testing steps
N/A - package bump
Screenshots/Recordings
Before
N/A - package bump
After
N/A - package bump
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Changes how Money account yield (APY) is derived for user-facing
balances and copy, with no in-repo code review of the package
diff—incorrect rates would be a product/trust issue rather than an auth
or data breach.
Overview
Updates
@metamask/money-account-balance-servicefrom ^2.3.0to ^2.4.0 in
package.jsonand refreshesyarn.lock. Theresolved 2.4.0 package now pulls
@metamask/money-account-api-data-service^0.4.0 as a transitivedependency (replacing the older ^0.2.0 tree entry in the lockfile).
There are no application source changes in this PR—Money UI
continues to consume balances/APY via existing hooks such as
useMoneyAccountBalance. The bump is intended to pick up librarybehavior for Veda API APR→APY handling and to avoid
double-compounding yield on the client (per MUSD-1229).
Reviewed by Cursor Bugbot for commit
c0606cf. Bugbot is set up for automated
code reviews on this repo. Configure
here.