test: multichain tests Appium migration - #34151
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
024b58c to
d28688b
Compare
🧪 Flaky unit test detection✅ All previously detected unit test flakiness issues in this PR have been fixed. This check is informational only and does not block merging. |
09b1df5 to
eabf483
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eabf483. Configure here.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Infrastructure changes: The CI workflow changes (removing SmokeMultiChainAPI from Detox workflows, adding to Appium workflows) need to be validated by running the actual SmokeMultiChainAPI tests through the new Appium pipeline. No performance impact: All changes are test infrastructure and test spec migrations — no app code was changed. No performance tests are needed. Performance Test Selection: |
|




Description
This PR took care of the following:
wallet-invokeMethod.spec.tsandwallet-notify.spec.tsthat were failing and disabled on DetoxChangelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Changes are confined to E2E/CI and test helpers; no production wallet or auth logic is modified.
Overview
Moves SmokeMultiChainAPI coverage from Detox E2E to Appium: new
tests/smoke-appium/multichain/specs (create/get/revoke session,wallet_invokeMethod, EIP-5792,wallet_sessionChanged, notify) and matching Android/iOS Appium workflow jobs (2-way split). Detoxmultichain-api-*-smokejobs andtests/smoke/multichain/*specs are removed from the smoke rollup.MultichainTestDApp is rewritten for Playwright/Appium: fixed localhost dapp on port 8093, Playwright login/browser flows, and CDP/WebView helpers instead of Detox WebView matchers. ChromeCdpHelpers gains MetaMask in-app WebView CDP (Android
webview_devtools_remote, iOS context switching) for click/evaluate/poll on dapp DOM; dapp URL matching now treats localhost like the multichain test dapp title fallback.wallet_notifyAppium test is present but skipped on emulator until live mainnet block events or a mock fixture exist.Reviewed by Cursor Bugbot for commit cda03c7. Bugbot is set up for automated code reviews on this repo. Configure here.