test(e2e): migrate token-approve confirmations to Appium (MMQA-2189)

[vivek-consensys]

Description

Migrates the Detox token-approve confirmation smoke specs to Appium as part of MMQA-2189 (PR1 of the confirmations transactions Detox→Appium migration).

• Ports approve, increase-allowance, and set-approval-for-all under tests/smoke-appium/confirmations/transactions/token-approve/
• Adds shared tests/flows/confirmations.flow.ts helpers (navigateToContractAndTap, confirmCloseAndAssertActivity)
• Updates confirmation POMs / framework helpers for Appium BottomSheet existence, iOS number-pad spending-cap edit, and Android CDP WebView taps
• Removes the Detox twins under tests/smoke/confirmations/transactions/token-approve/
• Makes simulations.ts safe to import under Appium (no Detox device at module load)

Local validation against main-e2e builds: approve / increase-allowance / set-approval-for-all green on iOS and Android.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-2189

Manual testing steps

Feature: Token approve confirmations (Appium smoke)

  Scenario: ERC-20 approve with spending-cap edit
    Given a fixture wallet connected to the local test dapp on Anvil
    When the user opens the ERC-20 approve confirmation and edits the spending cap
    And the user confirms the transaction
    Then Activity shows Approve as Confirmed

  Scenario: setApprovalForAll (ERC-721 / ERC-1155 / revoke)
    Given a fixture wallet connected to the local test dapp on Anvil
    When the user triggers setApprovalForAll or revoke from the test dapp
    And the user confirms the transaction
    Then Activity shows Set approval for all as Confirmed

Local Appium runs (main-e2e release binary):

# iOS
IOS_APP_PATH=build/ci-main-e2e/MetaMask.app \
IOS_SIMULATOR_UDID=<udid> \
yarn appium-smoke:ios -- confirmations/transactions/token-approve/

# Android
ANDROID_APK_PATH=build/ci-main-e2e/app-prod-release.apk \
ANDROID_AVD_NAME=<avd> \
yarn appium-smoke:android -- confirmations/transactions/token-approve/

Screenshots/Recordings

N/A — E2E test migration only; no product UI changes.

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Changes are limited to E2E tests and test helpers; no production app, auth, or wallet logic is modified.

Overview
Moves token-approve confirmation smoke coverage from Detox to Appium and deletes the matching specs under tests/smoke/confirmations/transactions/token-approve/. New Appium suites cover approve, increase-allowance, and set-approval-for-all (including ERC-721 revoke).

Shared confirmations.flow helpers drive the dapp → confirmation → Activity path: Android prefers CDP WebView clicks with a native tap fallback (no double-submit), then confirm, dismiss push opt-in, close browser, and assert Activity.

Test framework / POM updates target confirmation BottomSheets where Appium reports isDisplayed=false: expectElementToExist, confirm wait/gone and single-click confirm with retry in FooterActions, and iOS number-pad spending-cap edit in TokenApproveConfirmation. simulations.ts resolves the localhost sentinel URL at use-time via PlatformDetector so Appium can import it without Detox device. Minor Appium gesture fixes: W3C pointer long press, checkForDisplayed on Gestures.typeText, and iOS keyboard numberPad typing.

^{Reviewed by Cursor Bugbot for commit 1852bad. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamask-ci]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Pre-merge author checklist has unchecked items (e.g. "I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps, SmokeMMConnect
• Selected Performance tags: None (no tests recommended)
• Risk Level: high
• AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (test-framework-infra-change): Test framework infrastructure changed: tests/framework/Assertions.ts, tests/framework/Gestures.ts. Running all tests.

Performance Test Selection:
No app code changes in this PR — all changes are confined to test infrastructure (smoke specs, page objects, framework helpers, flows, mock responses). There is no impact on app performance metrics such as launch time, login, onboarding, asset loading, swaps, or perps. No performance test tags are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud