fix: bump @metamask/transaction-controller to 69.5.1 - #34412
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34412 +/- ##
=======================================
Coverage 85.06% 85.07%
=======================================
Files 6320 6324 +4
Lines 172287 172330 +43
Branches 42580 42591 +11
=======================================
+ Hits 146562 146610 +48
+ Misses 15693 15686 -7
- Partials 10032 10034 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
⚡ Performance Test Results
✅ All tests passed · 2 tests · 1 device 📱 Devices tested (1)Android: Google Pixel 8 Pro (v14.0) ✅ Passed Tests (2)
Branch: |
…ction-controller-69.5.1
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|



Description
Bumps
@metamask/transaction-controllerfrom 69.5.0 to 69.5.1 (dependency range and resolutions pin) to pick up theeth_estimateGasfix from MetaMask/core#9797: thevaluefield is now normalized to a canonical hex quantity (leading zero digits stripped, e.g.0x00→0x0,0x0de0b6b3a7640000→0xde0b6b3a7640000) before the estimation request is sent.Some RPC nodes use strict hex-quantity parsing (e.g. Go's
hexutil) and reject quantities with leading zero digits. When a dapp submitted a transaction with a padded value (as some ethers.jstoBeHex()usages produce), gas estimation failed on those networks and transactions could not be sent.Lockfile updated with
yarn install --mode=update-lockfile.Changelog
CHANGELOG entry: Fixed gas estimation failing on networks whose RPC nodes reject hex values with leading zeros (such as
0x00)Related issues
Fixes: CONF-1740
Manual testing steps
Screenshots/Recordings
N/A — dependency bump, no UI change.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Touches the core transaction/gas-estimation path via a patch bump only; behavior change is narrow but affects all EVM sends that estimate gas.
Overview
Upgrades
@metamask/transaction-controllerfrom 69.5.0 to 69.5.1 inpackage.json(dependency range and resolutions pin) and refreshesyarn.lock. There are no mobile app source changes.The new patch pulls in upstream behavior that canonicalizes transaction
valueto hex quantity beforeeth_estimateGas, so padded values like0x00or0x0de0b6b3a7640000are sent as0x0/0xde0b6b3a7640000. That unblocks gas estimation and sending on RPCs that reject non-canonical hex (e.g. strict Gohexutilparsers).Reviewed by Cursor Bugbot for commit a9fc379. Bugbot is set up for automated code reviews on this repo. Configure here.