Use side effects for wallet_snap permission#1301
Merged
Merged
Conversation
GuillaumeRx
force-pushed
the
gr/use-side-effects
branch
2 times, most recently
from
2ec5a57 to
f35995f
Compare
GuillaumeRx
changed the title
wallet_snap permissionwallet_snap permission
Contributor
Author
|
Waiting on a release of |
GuillaumeRx
force-pushed
the
gr/use-side-effects
branch
from
95f29b7 to
66679ac
Compare
FrederikBolding
previously approved these changes
Mar 29, 2023
FrederikBolding
previously approved these changes
Mar 29, 2023
FrederikBolding
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
wallet_snapto install the requested snaps as a side-effect and reworks therequestSnapsmethod to let thewallet_snapside effect handle the snap install in most cases.Fixes #1306