Skip to content

feat: Allow additional icon colors#3895

Merged
FrederikBolding merged 1 commit intomainfrom
fb/icon-colors
Mar 10, 2026
Merged

feat: Allow additional icon colors#3895
FrederikBolding merged 1 commit intomainfrom
fb/icon-colors

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Mar 10, 2026

Allow a couple more icon colors, e.g. warning, error, success.

https://consensyssoftware.atlassian.net/browse/WPC-515


Note

Low Risk
Small type/validation expansion with no changes to rendering logic; risk is limited to potential mismatches with downstream styling expectations for the new color values.

Overview
Expands the Icon component to accept additional semantic colors by introducing an IconColor type and allowing error, success, and warning in IconProps.

Updates JSX validation (IconStruct) to permit the same new color literals so these values pass runtime element validation.

Written by Cursor Bugbot for commit 2a3bbf0. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner March 10, 2026 09:39
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (b0f99c1) to head (2a3bbf0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3895   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         425      425           
  Lines       12325    12325           
  Branches     1926     1926           
=======================================
  Hits        12149    12149           
  Misses        176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Mar 10, 2026
Merged via the queue into main with commit 8b6eeff Mar 10, 2026
130 checks passed
@FrederikBolding FrederikBolding deleted the fb/icon-colors branch March 10, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants