Skip to content

feat: Allow additional icon colors #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Mar 10, 2026
Merged

feat: Allow additional icon colors #3895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/snaps-sdk/src/jsx/components/Icon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,17 @@ export enum IconName {
X = 'x',
}

/**
* The colors available to the {@link Link} component.
*/
export type IconColor =
| 'default'
| 'primary'
| 'muted'
| 'error'
| 'success'
| 'warning';

/**
* The props of the {@link Icon} component.
*
Expand All @@ -288,7 +299,7 @@ export enum IconName {
*/
export type IconProps = {
name: `${IconName}`;
color?: 'default' | 'primary' | 'muted' | undefined;
color?: IconColor | undefined;
size?: 'md' | 'inherit' | undefined;
};

Expand Down
9 changes: 8 additions & 1 deletion packages/snaps-sdk/src/jsx/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,14 @@ const IconNameStruct: Struct<`${IconName}`, null> = nullUnion(
export const IconStruct: Describe<IconElement> = element('Icon', {
name: IconNameStruct,
color: optional(
nullUnion([literal('default'), literal('primary'), literal('muted')]),
nullUnion([
literal('default'),
literal('primary'),
literal('muted'),
literal('error'),
literal('success'),
literal('warning'),
]),
),
size: optional(nullUnion([literal('md'), literal('inherit')])),
});
Expand Down
Loading