Skip to content

refactor!: Rename MultichainRouter to MultichainRoutingService and use messenger exposed methods pattern#3913

Merged
Mrtenz merged 8 commits intocontroller-refactorsfrom
mrtenz/multichain-router-refactor
Mar 24, 2026
Merged

refactor!: Rename MultichainRouter to MultichainRoutingService and use messenger exposed methods pattern#3913
Mrtenz merged 8 commits intocontroller-refactorsfrom
mrtenz/multichain-router-refactor

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 23, 2026

This updates the MultichainRouter to use messenger exposed methods. Actions were already named properly.


Note

Medium Risk
Breaking rename and action-type reshaping will require downstream updates, and the switch to SnapController:getRunnableSnaps changes the dependency contract for protocol snap routing. Runtime logic appears largely unchanged but touches request routing paths.

Overview
Renames the multichain RPC router from MultichainRouter to MultichainRoutingService and updates exported types/namespace action strings accordingly (breaking change).

Refactors messenger integration to use registerMethodActionHandlers with auto-generated method action types, and changes protocol-snap discovery to call SnapController:getRunnableSnaps directly (no longer requires SnapController:getAllSnaps). Tests and controller test-utils are updated to use the new messenger helpers and action names, and the changelog documents both breaking changes.

Written by Cursor Bugbot for commit 5b0d482. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review March 23, 2026 14:53
@Mrtenz Mrtenz requested a review from a team as a code owner March 23, 2026 14:53
Mrtenz and others added 2 commits March 23, 2026 16:00
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (controller-refactors@2799c4c). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             controller-refactors    #3913   +/-   ##
=======================================================
  Coverage                        ?   98.55%           
=======================================================
  Files                           ?      425           
  Lines                           ?    12335           
  Branches                        ?     1935           
=======================================================
  Hits                            ?    12157           
  Misses                          ?      178           
  Partials                        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz changed the title refactor!: Refactor MultichainRouter to use messenger exposed methods refactor!: Rename MultichainRouter to MultichainRoutingService and use messenger exposed methods pattern Mar 24, 2026
@Mrtenz Mrtenz merged commit 254591e into controller-refactors Mar 24, 2026
127 checks passed
@Mrtenz Mrtenz deleted the mrtenz/multichain-router-refactor branch March 24, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants