fix: Rename duplicate identifiers#4069
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4069 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 428 428
Lines 12484 12484
Branches 1975 1975
=======================================
Hits 12309 12309
Misses 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cryptodev-2s
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename duplicate identifiers in test-snaps to prevent collisions during E2E.
Note
Low Risk
Test-harness DOM id changes only; no production or snap runtime behavior is affected.
Overview
Renames shared
rpcResultDOM ids on the JSX and Preinstalled snap demo pages so each feature exposes a unique result span for tests.Jsx.tsxnow usesjsxResult;Preinstalled.tsxusespreinstalledResult. The JSON-RPC snap page keepsrpcResult, so E2E selectors no longer collide when multiple snap panels render on one page.Reviewed by Cursor Bugbot for commit bf73b1b. Bugbot is set up for automated code reviews on this repo. Configure here.