Skip to content

fix: Rename duplicate identifiers#4069

Merged
FrederikBolding merged 1 commit into
mainfrom
fb/fix-duplicate-ids
Jul 8, 2026
Merged

fix: Rename duplicate identifiers#4069
FrederikBolding merged 1 commit into
mainfrom
fb/fix-duplicate-ids

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented Jul 7, 2026

Copy link
Copy Markdown
Member

Rename duplicate identifiers in test-snaps to prevent collisions during E2E.


Note

Low Risk
Test-harness DOM id changes only; no production or snap runtime behavior is affected.

Overview
Renames shared rpcResult DOM ids on the JSX and Preinstalled snap demo pages so each feature exposes a unique result span for tests.

Jsx.tsx now uses jsxResult; Preinstalled.tsx uses preinstalledResult. The JSON-RPC snap page keeps rpcResult, so E2E selectors no longer collide when multiple snap panels render on one page.

Reviewed by Cursor Bugbot for commit bf73b1b. Bugbot is set up for automated code reviews on this repo. Configure here.

@FrederikBolding FrederikBolding marked this pull request as ready for review July 7, 2026 15:55
@FrederikBolding FrederikBolding requested a review from a team as a code owner July 7, 2026 15:55
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (d4cf201) to head (bf73b1b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4069   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         428      428           
  Lines       12484    12484           
  Branches     1975     1975           
=======================================
  Hits        12309    12309           
  Misses        175      175           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit f7da185 Jul 8, 2026
132 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-duplicate-ids branch July 8, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants