Skip to content

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 16, 2024

@metamask/gas-fee-controller is defined as devDependency, but as actually used in runtime.

Fixed

  • Move @metamask/gas-fee-controller from devDependencies to dependencies.
    • Add missing peerDependency @metamask/network-controller@^3.0.0, inherited from @metamask/gas-fee-controller

Related

This was referenced Apr 16, 2024
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Apr 16, 2024
@legobeat legobeat force-pushed the deps-gas-fee-controller branch from e7a6889 to 8f8b91d Compare April 17, 2024 08:21
@legobeat legobeat marked this pull request as ready for review April 17, 2024 08:21
@legobeat legobeat requested a review from dan437 as a code owner April 17, 2024 08:21
@legobeat legobeat requested review from a team and nikoferro April 17, 2024 08:21
Copy link

@nikoferro nikoferro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikoferro nikoferro merged commit 5d509c6 into main Apr 17, 2024
@nikoferro nikoferro deleted the deps-gas-fee-controller branch April 17, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants