Skip to content

Conversation

legobeat
Copy link
Contributor

Follow-up to #193

Changes

  • Remove unused dependency @metamask/controllers
  • Remove unused devDependency @metamask/ethjs-query
  • Move @metamask/composable-controller from dependencies to devDependencies
    • This is only used in tests

@legobeat legobeat requested a review from dan437 as a code owner April 16, 2024 23:07
@legobeat legobeat requested review from a team and nikoferro April 16, 2024 23:07
Copy link

socket-security bot commented Apr 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/elliptic@6.5.5 None +4 248 kB indutny

🚮 Removed packages: npm/@metamask/controllers@33.0.0, npm/@metamask/ethjs-query@0.5.3, npm/elliptic@6.5.4, npm/eth-sig-util@3.0.1, npm/tweetnacl-util@0.15.1

View full report↗︎

Copy link

@nikoferro nikoferro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikoferro nikoferro merged commit 88a4908 into main Apr 17, 2024
@nikoferro nikoferro deleted the deps-remove-unused branch April 17, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants